Re: (subset) [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range

Re: (subset) [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range

[Philippe Simons]

Tested on my RG35XX-H, v6.10rc3 boots with the patch applied

Tested-by: Philippe Simons <simons.philippe@gmail.com>

Re: (subset) [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range

[Lee Jones]

On Fri, 14 Jun 2024, Philippe Simons wrote:

> Tested on my RG35XX-H, v6.10rc3 boots with the patch applied
> 
> Tested-by: Philippe Simons <simons.philippe@gmail.com>

It looks like the way you replied to this mail failed to attach itself
to the original thread, so I have no idea what this tag applies to.

However this point may be moot since, by the look of the subject line,
you're attempting to apply tags to patches which have already been
committed.

-- 
Lee Jones [李琼斯]

[PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range

[Andre Przywara]

While we list the "IRQ status *and acknowledge*" registers as volatile
in the MFD description, they are missing from the writable range array,
so acknowledging any interrupts was met with an -EIO error.
This error propagates up, leading to the whole AXP717 driver failing to
probe, which is fatal to most systems using this PMIC, since most
peripherals refer one of the PMIC voltage rails.
This wasn't noticed on the initial submission, since the interrupt was
completely missing at this point, but the DTs now merged describe the
interrupt, creating the problem.

Add the five registers that hold those bits to the writable array.

This fixes the boot on the Anbernic systems using the AXP717 PMIC.

Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC")
Reported-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
Hi,

the patch itself is unchanged from v2 sent in April, but the commit
message was updated to give rationale for the Fixes: tag.
Please take this as a fix into v6.10.

Thanks,
Andre

 drivers/mfd/axp20x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index f2c0f144c0fc3..dacd3c96c9f57 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -210,6 +210,7 @@ static const struct regmap_access_table axp313a_volatile_table = {
 
 static const struct regmap_range axp717_writeable_ranges[] = {
 	regmap_reg_range(AXP717_IRQ0_EN, AXP717_IRQ4_EN),
+	regmap_reg_range(AXP717_IRQ0_STATE, AXP717_IRQ4_STATE),
 	regmap_reg_range(AXP717_DCDC_OUTPUT_CONTROL, AXP717_CPUSLDO_CONTROL),
 };
 
-- 
2.39.4

Re: (subset) [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range

[Lee Jones]

On Fri, 14 Jun 2024 00:31:04 +0100, Andre Przywara wrote:
> While we list the "IRQ status *and acknowledge*" registers as volatile
> in the MFD description, they are missing from the writable range array,
> so acknowledging any interrupts was met with an -EIO error.
> This error propagates up, leading to the whole AXP717 driver failing to
> probe, which is fatal to most systems using this PMIC, since most
> peripherals refer one of the PMIC voltage rails.
> This wasn't noticed on the initial submission, since the interrupt was
> completely missing at this point, but the DTs now merged describe the
> interrupt, creating the problem.
> 
> [...]

Applied, thanks!

[1/1] mfd: axp20x: AXP717: Fix missing IRQ status registers range
      commit: 569c5136baf12c3b8dd137ac356f2a7ceb38bdb5

--
Lee Jones [李琼斯]