[PATCH v3 0/2] NanoPi NEO Plus2: Fix regulators and assign them

[PATCH v3 0/2] NanoPi NEO Plus2: Fix regulators and assign them

[Kryštof Černý]

Just minor changes based on feedback.

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
Changes in v3:
- Renamed patches - added prefix.
- Remove the patch that added regulator to emmc.
- Link to v2: https://lore.kernel.org/r/20240827-nanopi-neo-plus2-regfix-v2-0-497684ec82c7@gmail.com

---
Kryštof Černý (2):
      arm64: dts: allwinner: H5: NanoPi Neo Plus2: Fix regulators
      arm64: dts: allwinner: H5: NanoPi NEO Plus2: Use regulators for pio

 .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)
---
base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12
change-id: 20240827-nanopi-neo-plus2-regfix-b60116ce12ca

Best regards,
-- 
Kryštof Černý <cleverline1mc@gmail.com>

[PATCH v3 1/2] arm64: dts: allwinner: H5: NanoPi Neo Plus2: Fix regulators

[Kryštof Černý]

Added the main board 5 V supply regulator,
a 2.5 V supply regulator for GMAC PHY IO and correct vin-supply elements.

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
 .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
index b69032c44557..dee4cd82636b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
@@ -45,16 +45,40 @@ reg_gmac_3v3: gmac-3v3 {
 		startup-delay-us = <100000>;
 		enable-active-high;
 		gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>;
+		vin-supply = <&reg_vcc3v3>;
+	};
+
+	reg_gmac_2v5: gmac-2v5 {
+		/* 2V5 supply for GMAC PHY IO */
+		compatible = "regulator-fixed";
+		regulator-name = "gmac-2v5";
+		regulator-min-microvolt = <2500000>;
+		regulator-max-microvolt = <2500000>;
+		regulator-always-on;
+		vin-supply = <&reg_vcc3v3>;
+	};
+
+	reg_vcc5v: regulator-vcc5v {
+		/* board 5V supply from micro USB or pin headers */
+		compatible = "regulator-fixed";
+		regulator-name = "vcc-5v";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
 	};
 
 	reg_vcc3v3: vcc3v3 {
+		/* board 3V3 supply by SY8089A */
 		compatible = "regulator-fixed";
 		regulator-name = "vcc3v3";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+		vin-supply = <&reg_vcc5v>;
 	};
 
 	vdd_cpux: gpio-regulator {
+		/* cpu voltage regulator MP2143DJ */
 		compatible = "regulator-gpio";
 		regulator-name = "vdd-cpux";
 		regulator-type = "voltage";
@@ -66,6 +90,7 @@ vdd_cpux: gpio-regulator {
 		gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
 		gpios-states = <0x1>;
 		states = <1100000 0>, <1300000 1>;
+		vin-supply = <&reg_vcc5v>;
 	};
 
 	wifi_pwrseq: pwrseq {

-- 
2.39.2

[PATCH v3 2/2] arm64: dts: allwinner: H5: NanoPi NEO Plus2: Use regulators for pio

[Kryštof Černý]

Pin controllers pio and r_pio will have proper regulators assigned.

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
index dee4cd82636b..526443bb736c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
@@ -171,6 +171,18 @@ &ohci3 {
 	status = "okay";
 };
 
+&pio {
+	vcc-pa-supply = <&reg_vcc3v3>;
+	vcc-pc-supply = <&reg_vcc3v3>;
+	vcc-pd-supply = <&reg_gmac_2v5>;
+	vcc-pf-supply = <&reg_vcc3v3>;
+	vcc-pg-supply = <&reg_vcc3v3>;
+};
+
+&r_pio {
+	vcc-pl-supply = <&reg_vcc3v3>;
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pa_pins>;

-- 
2.39.2

Re: [PATCH v3 0/2] NanoPi NEO Plus2: Fix regulators and assign them

[Andre Przywara]

On Thu, 05 Sep 2024 19:37:09 +0200
Kryštof Černý <cleverline1mc@gmail.com> wrote:

Hi Kryštof,

thanks for the follow-up!

> Just minor changes based on feedback.
> 
> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>

There is no need for a Signed-off-by: in the cover letter.
But you are supposed to add any tags, like my "Reviewed-by", to a new
revision.
I guess unfortunately you missed the v6.12 merge window by an hour or
so, but in any case I hope Chen-Yu can copy in the tags when applying.

> ---
> Changes in v3:
> - Renamed patches - added prefix.
> - Remove the patch that added regulator to emmc.
> - Link to v2: https://lore.kernel.org/r/20240827-nanopi-neo-plus2-regfix-v2-0-497684ec82c7@gmail.com

Thanks for the changelog, that's helpful. Ideally you would stack this
up with the changes from previous revisions, so listing the changes
from v1 .. v2 here as well.

Cheers,
Andre

> 
> ---
> Kryštof Černý (2):
>       arm64: dts: allwinner: H5: NanoPi Neo Plus2: Fix regulators
>       arm64: dts: allwinner: H5: NanoPi NEO Plus2: Use regulators for pio
> 
>  .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> ---
> base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12
> change-id: 20240827-nanopi-neo-plus2-regfix-b60116ce12ca
> 
> Best regards,

Re: [PATCH v3 0/2] NanoPi NEO Plus2: Fix regulators and assign them

[Chen-Yu Tsai]

From: Chen-Yu Tsai <wens@csie.org>

On Thu, 05 Sep 2024 19:37:09 +0200, Kryštof Černý wrote:
> Just minor changes based on feedback.
> 
> 

Applied to sunxi/dt-for-6.12 in sunxi/linux.git, thanks!

[1/2] arm64: dts: allwinner: H5: NanoPi Neo Plus2: Fix regulators
      https://git.kernel.org/sunxi/linux/c/37ed8e75c660
[2/2] arm64: dts: allwinner: H5: NanoPi NEO Plus2: Use regulators for pio
      https://git.kernel.org/sunxi/linux/c/605f56405a67

I also changed the "H5" in the subject to lowercase, matching most other
commits.


Best regards,
-- 
Chen-Yu Tsai <wens@csie.org>