Re: [PATCH net 0/2] allwinner: a523: Rename emac0 to gmac0

[Andre Przywara <andre.przywara@arm.com>]

On Sat, 28 Jun 2025 13:44:36 +0800
Chen-Yu Tsai <wens@kernel.org> wrote:

Hi,

> From: Chen-Yu Tsai <wens@csie.org>
> 
> Hi folks,
> 
> This small series aims to align the name of the first ethernet
> controller found on the Allwinner A523 SoC family with the name
> found in the datasheets. It renames the compatible string and
> any other references from "emac0" to "gmac0".

To be honest I am not a big fan of those cosmetic renames when it
touches DT files. It seems to not break compatibility in this case,
since we don't use the specific compatible string, but leaves a bitter
taste anyway. Also I pick DT patches out of -rc releases for U-Boot,
and did so internally already, so it's not without churns.

So is this really necessary, and what is the purpose of this patch?
I am fine with using GMAC for the GMAC200 part in the SoC, but the A64,
H6, H616, A133 all use the same IP - as the fallback compatible proves -
and they call it all EMAC.

That's not a NAK, but just wanted to bring this up.

Cheers,
Andre. 

> When support of the hardware was introduced, the name chosen was
> "EMAC", which followed previous generations. However the datasheets
> use the name "GMAC" instead, likely because there is another "GMAC"
> based on a newer DWMAC IP.
> 
> The first patch fixes the compatible string entry in the device tree
> binding.
> 
> The second patch fixes all references in the existing device trees.
> 
> Since this was introduced in v6.16-rc1, I hope to land this for v6.16
> as well.
> 
> There's a small conflict in patch one around the patch context with 
> 
>     dt-bindings: net: sun8i-emac: Add A100 EMAC compatible
> 
> that just landed in net-next today. I will leave this patch to the net
> mainainers to merge to avoid making a bigger mess. Once that is landed
> I will merge the second patch through the sunxi tree.
> 
> 
> Thanks
> ChenYu
> 
> 
> Chen-Yu Tsai (2):
>   dt-bindings: net: sun8i-emac: Rename A523 EMAC0 to GMAC0
>   arm64: dts: allwinner: a523: Rename emac0 to gmac0
> 
>  .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml  | 2 +-
>  arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi              | 6 +++---
>  arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts     | 4 ++--
>  arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts     | 4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)
>