Re: [PATCH 2/2] arm64: tegra: disable Tegra234 sce-fabric node

[Jon Hunter <jonathanh@nvidia.com>]

On 13/12/2024 00:03, Ivy Huang wrote:
> From: Sumit Gupta <sumitg@nvidia.com>
> 
> Access to safety cluster engine (SCE) fabric registers was blocked
> by firewall after the introduction of Functional Safety Island in
> Tegra234. After that, any access by software to SCE registers is
> correctly resulting in the internal bus error. However, when CPUs
> try accessing the SCE-fabric registers to print error info,
> another firewall error occurs as the fabric registers are also
> firewall protected. This results in a second error to be printed.
> Disable the SCE fabric node to avoid printing the misleading error.
> The first error info will be printed by the interrupt from the
> fabric causing the actual access.
> 
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> Signed-off-by: Ivy Huang <yijuh@nvidia.com>
> ---
>   arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index d08faf6bb505..05a771ab1ed5 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -3815,7 +3815,7 @@
>   			compatible = "nvidia,tegra234-sce-fabric";
>   			reg = <0x0 0xb600000 0x0 0x40000>;
>   			interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> -			status = "okay";
> +			status = "disabled";
>   		};
>   
>   		rce-fabric@be00000 {


We need the same fixes tag on this one as well ...

Fixes: 302e154000ec ("arm64: tegra: Add node for CBB 2.0 on Tegra234")

Otherwise ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic