Linux Tegra architecture development
 help / color / mirror / Atom feed
From: Ivy Huang <yijuh@nvidia.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	Brad Griffis <bgriffis@nvidia.com>
Cc: Sumit Gupta <sumitg@nvidia.com>, Ivy Huang <yijuh@nvidia.com>
Subject: [PATCH 2/2] arm64: tegra: disable Tegra234 sce-fabric node
Date: Fri, 13 Dec 2024 00:03:05 +0000	[thread overview]
Message-ID: <20241213000305.3533971-3-yijuh@nvidia.com> (raw)
In-Reply-To: <20241213000305.3533971-1-yijuh@nvidia.com>

From: Sumit Gupta <sumitg@nvidia.com>

Access to safety cluster engine (SCE) fabric registers was blocked
by firewall after the introduction of Functional Safety Island in
Tegra234. After that, any access by software to SCE registers is
correctly resulting in the internal bus error. However, when CPUs
try accessing the SCE-fabric registers to print error info,
another firewall error occurs as the fabric registers are also
firewall protected. This results in a second error to be printed.
Disable the SCE fabric node to avoid printing the misleading error.
The first error info will be printed by the interrupt from the
fabric causing the actual access.

Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
Signed-off-by: Ivy Huang <yijuh@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
index d08faf6bb505..05a771ab1ed5 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
@@ -3815,7 +3815,7 @@
 			compatible = "nvidia,tegra234-sce-fabric";
 			reg = <0x0 0xb600000 0x0 0x40000>;
 			interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
-			status = "okay";
+			status = "disabled";
 		};
 
 		rce-fabric@be00000 {
-- 
2.17.1


  parent reply	other threads:[~2024-12-13  0:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  0:03 [PATCH 0/2] Tegra234 fabric fixes Ivy Huang
2024-12-13  0:03 ` [PATCH 1/2] arm64: tegra: fix typo in Tegra234 dce-fabric compatible Ivy Huang
2024-12-13  2:32   ` Brad Griffis
2024-12-13  9:44   ` Jon Hunter
2024-12-13 10:22     ` Thierry Reding
2024-12-13 11:11       ` Krzysztof Kozlowski
2024-12-13 11:10   ` Krzysztof Kozlowski
2024-12-18  2:08     ` Brad Griffis
2024-12-13  0:03 ` Ivy Huang [this message]
2024-12-13  2:32   ` [PATCH 2/2] arm64: tegra: disable Tegra234 sce-fabric node Brad Griffis
2024-12-13  9:45   ` Jon Hunter
2024-12-13 10:28   ` Thierry Reding
2024-12-14  0:39     ` Brad Griffis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241213000305.3533971-3-yijuh@nvidia.com \
    --to=yijuh@nvidia.com \
    --cc=bgriffis@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sumitg@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox