Re: [PATCH 1/2] arm64: tegra: fix typo in Tegra234 dce-fabric compatible

[Jon Hunter <jonathanh@nvidia.com>]

On 13/12/2024 00:03, Ivy Huang wrote:
> From: Sumit Gupta <sumitg@nvidia.com>
> 
> Fix typo in the compatible string of Tegra234 dce-fabric.
> 
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> Signed-off-by: Ivy Huang <yijuh@nvidia.com>
> ---
>   arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index 984c85eab41a..d08faf6bb505 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -3995,7 +3995,7 @@
>   		};
>   
>   		dce-fabric@de00000 {
> -			compatible = "nvidia,tegra234-sce-fabric";
> +			compatible = "nvidia,tegra234-dce-fabric";
>   			reg = <0x0 0xde00000 0x0 0x40000>;
>   			interrupts = <GIC_SPI 381 IRQ_TYPE_LEVEL_HIGH>;
>   			status = "okay";


LGTM! However, we are missing a 'Fixes' tag. We should add the following 
above the 'signed-off-by'.

Fixes: 302e154000ec ("arm64: tegra: Add node for CBB 2.0 on Tegra234")

Thierry, do you want to apply the fixes tag when merging? Could also be 
a candidate for stable.

Otherwise ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic