* [PATCH] pci: tegra: use correct gpio/consumer.h header
@ 2019-06-28 10:29 Arnd Bergmann
2019-06-28 10:46 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-06-28 10:29 UTC (permalink / raw)
To: Thierry Reding, Lorenzo Pieralisi, Bjorn Helgaas, Jonathan Hunter
Cc: Arnd Bergmann, Manikanta Maddireddy, Thierry Reding, Vidya Sagar,
linux-tegra, linux-pci, linux-kernel
linux/gpio.h is not the correct header for modern interfaces and
causes a build failure without CONFIG_GPIOLIB:
drivers/pci/controller/pci-tegra.c: In function 'tegra_pcie_port_reset':
drivers/pci/controller/pci-tegra.c:551:3: error: implicit declaration of function 'gpiod_set_value'; did you mean 'gpio_set_value'? [-Werror=implicit-function-declaration]
gpiod_set_value(port->reset_gpio, 1);
^~~~~~~~~~~~~~~
Use linux/gpio/consumer.h instead.
Fixes: 5e5e9c23f82a ("PCI: tegra: Add support for GPIO based PERST#")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pci/controller/pci-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 9cc03a2549c0..1775b88c0aec 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -17,7 +17,7 @@
#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/export.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/iopoll.h>
#include <linux/irq.h>
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pci: tegra: use correct gpio/consumer.h header
2019-06-28 10:29 [PATCH] pci: tegra: use correct gpio/consumer.h header Arnd Bergmann
@ 2019-06-28 10:46 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2019-06-28 10:46 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Thierry Reding, Bjorn Helgaas, Jonathan Hunter,
Manikanta Maddireddy, Thierry Reding, Vidya Sagar, linux-tegra,
linux-pci, linux-kernel
On Fri, Jun 28, 2019 at 12:29:45PM +0200, Arnd Bergmann wrote:
> linux/gpio.h is not the correct header for modern interfaces and
> causes a build failure without CONFIG_GPIOLIB:
>
> drivers/pci/controller/pci-tegra.c: In function 'tegra_pcie_port_reset':
> drivers/pci/controller/pci-tegra.c:551:3: error: implicit declaration of function 'gpiod_set_value'; did you mean 'gpio_set_value'? [-Werror=implicit-function-declaration]
> gpiod_set_value(port->reset_gpio, 1);
> ^~~~~~~~~~~~~~~
>
> Use linux/gpio/consumer.h instead.
>
> Fixes: 5e5e9c23f82a ("PCI: tegra: Add support for GPIO based PERST#")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pci/controller/pci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Squashed in the respective commit in pci/tegra, thanks for the fix
Arnd.
Lorenzo
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 9cc03a2549c0..1775b88c0aec 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -17,7 +17,7 @@
> #include <linux/debugfs.h>
> #include <linux/delay.h>
> #include <linux/export.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/iopoll.h>
> #include <linux/irq.h>
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-28 10:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-28 10:29 [PATCH] pci: tegra: use correct gpio/consumer.h header Arnd Bergmann
2019-06-28 10:46 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox