From: Breno Leitao <leitao@debian.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-tegra@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, rmikey@meta.com,
Breno Leitao <leitao@debian.org>,
kernel-team@meta.com
Subject: [PATCH 0/3] spi: tegra210-quad: Improve reset and tx failures
Date: Mon, 17 Mar 2025 08:44:00 -0700 [thread overview]
Message-ID: <20250317-tegra-v1-0-78474efc0386@debian.org> (raw)
I maintain several hosts with tegra210-quad controllers, some of which
experience data transmission failures. Debugging these issues has been
challenging due to excessive log messages from the driver.
All my tegra210-quad systems report "device reset failed" at boot and
during recovery attempts. Upon investigation, I found this message is
misleading - the driver isn't failing to reset the device, but rather
device_reset() returns non-zero because no _RST ACPI method exists. The
first patch replaces this with device_reset_optional(), which doesn't
return negative values when ACPI handlers are absent.
Additionally, when transmission failures occur, the kernel logs become
flooded with repetitive warnings and error messages from tegra210-quad,
making them nearly unreadable. The second and third patches in this
series address this by:
1. Using WARN_ON_ONCE instead of WARN_ON to reduce stack trace spam
2. Rate-limiting error messages and removing redundant information
These improvements maintain necessary error reporting while significantly
reducing log noise, making debugging of actual issues more feasible.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (3):
spi: tegra210-quad: use device_reset_optional() instead of device_reset()
spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts
spi: tegra210-quad: add rate limiting and simplify timeout error message
drivers/spi/spi-tegra210-quad.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
---
base-commit: 4701f33a10702d5fc577c32434eb62adde0a1ae1
change-id: 20250317-tegra-1712e60604e6
Best regards,
--
Breno Leitao <leitao@debian.org>
next reply other threads:[~2025-03-17 15:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 15:44 Breno Leitao [this message]
2025-03-17 15:44 ` [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset() Breno Leitao
2025-03-17 16:45 ` Mark Brown
2025-03-17 16:56 ` Breno Leitao
2025-03-17 17:24 ` Mark Brown
2025-03-18 10:36 ` Breno Leitao
2025-03-18 12:48 ` Mark Brown
2025-03-18 17:02 ` Breno Leitao
2025-03-18 17:34 ` Mark Brown
2025-03-18 18:29 ` Breno Leitao
2025-03-18 18:32 ` Breno Leitao
2025-03-18 19:00 ` Arnd Bergmann
2025-03-18 19:13 ` Mark Brown
2025-03-18 20:07 ` Arnd Bergmann
2025-03-19 10:09 ` Breno Leitao
2025-03-19 18:26 ` Thierry Reding
2025-03-19 18:53 ` Breno Leitao
2025-03-21 12:40 ` Thierry Reding
2025-03-21 16:28 ` Breno Leitao
2025-03-24 13:17 ` Thierry Reding
2025-03-25 16:56 ` Breno Leitao
2025-03-25 17:05 ` Thierry Reding
2025-03-28 13:18 ` Breno Leitao
2025-03-19 13:11 ` Mark Brown
2025-03-18 18:35 ` Mark Brown
2025-03-18 19:08 ` Breno Leitao
2025-03-18 19:16 ` Mark Brown
2025-03-17 15:44 ` [PATCH 2/3] spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts Breno Leitao
2025-03-17 15:44 ` [PATCH 3/3] spi: tegra210-quad: add rate limiting and simplify timeout error message Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317-tegra-v1-0-78474efc0386@debian.org \
--to=leitao@debian.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-team@meta.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rmikey@meta.com \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox