From: "Arnd Bergmann" <arnd@arndb.de>
To: "Breno Leitao" <leitao@debian.org>, "Mark Brown" <broonie@debian.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Sowjanya Komatineni" <skomatineni@nvidia.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
linux-tegra@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, rmikey@meta.com,
kernel-team@meta.com,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
noodles@earth.li, "Jarkko Sakkinen" <jarkko@kernel.org>,
"Peter Huewe" <peterhuewe@gmx.de>,
jgg@ziepe.c
Subject: Re: [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset()
Date: Tue, 18 Mar 2025 20:00:05 +0100 [thread overview]
Message-ID: <b3da27ce-161b-4462-a608-c36f4b0696ce@app.fastmail.com> (raw)
In-Reply-To: <20250318-psychedelic-thundering-guppy-22bba2@leitao>
On Tue, Mar 18, 2025, at 19:32, Breno Leitao wrote:
> On Tue, Mar 18, 2025 at 11:29:26AM -0700, Breno Leitao wrote:
>> On Tue, Mar 18, 2025 at 05:34:55PM +0000, Mark Brown wrote:
>>
>> Summary of the proiblem: tpm_tis is trying to read random numbers
>> through a dead SPI controller. That causes infinite amounts of warnings
>> on the kernel, given that the controller is WARNing on time outs (which
>> is being fixed in one of the patches in this patchset).
>>
>> Question: Should tpm_tis be aware that the underneath SPI controller is
>> dead, and eventually get unplugged?
>
> Adding Arnd to the email.
Hi Breno,
That does sound like the easiest answer: if the spi controller driver
knows that it needs a reset but there is no reset controller, shutting
itself down and removing its child devices seems like the least
offensive action.
No idea if there are other spi controllers that do something like this.
Arnd
next prev parent reply other threads:[~2025-03-18 19:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 15:44 [PATCH 0/3] spi: tegra210-quad: Improve reset and tx failures Breno Leitao
2025-03-17 15:44 ` [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset() Breno Leitao
2025-03-17 16:45 ` Mark Brown
2025-03-17 16:56 ` Breno Leitao
2025-03-17 17:24 ` Mark Brown
2025-03-18 10:36 ` Breno Leitao
2025-03-18 12:48 ` Mark Brown
2025-03-18 17:02 ` Breno Leitao
2025-03-18 17:34 ` Mark Brown
2025-03-18 18:29 ` Breno Leitao
2025-03-18 18:32 ` Breno Leitao
2025-03-18 19:00 ` Arnd Bergmann [this message]
2025-03-18 19:13 ` Mark Brown
2025-03-18 20:07 ` Arnd Bergmann
2025-03-19 10:09 ` Breno Leitao
2025-03-19 18:26 ` Thierry Reding
2025-03-19 18:53 ` Breno Leitao
2025-03-21 12:40 ` Thierry Reding
2025-03-21 16:28 ` Breno Leitao
2025-03-24 13:17 ` Thierry Reding
2025-03-25 16:56 ` Breno Leitao
2025-03-25 17:05 ` Thierry Reding
2025-03-28 13:18 ` Breno Leitao
2025-03-19 13:11 ` Mark Brown
2025-03-18 18:35 ` Mark Brown
2025-03-18 19:08 ` Breno Leitao
2025-03-18 19:16 ` Mark Brown
2025-03-17 15:44 ` [PATCH 2/3] spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts Breno Leitao
2025-03-17 15:44 ` [PATCH 3/3] spi: tegra210-quad: add rate limiting and simplify timeout error message Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3da27ce-161b-4462-a608-c36f4b0696ce@app.fastmail.com \
--to=arnd@arndb.de \
--cc=broonie@debian.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.c \
--cc=jonathanh@nvidia.com \
--cc=kernel-team@meta.com \
--cc=ldewangan@nvidia.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=noodles@earth.li \
--cc=peterhuewe@gmx.de \
--cc=rmikey@meta.com \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox