From: Mark Brown <broonie@debian.org>
To: Breno Leitao <leitao@debian.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-tegra@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, rmikey@meta.com,
kernel-team@meta.com
Subject: Re: [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset()
Date: Mon, 17 Mar 2025 16:45:31 +0000 [thread overview]
Message-ID: <22ffa8f5-6590-4602-853d-ceffed580f22@sirena.org.uk> (raw)
In-Reply-To: <20250317-tegra-v1-1-78474efc0386@debian.org>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Mon, Mar 17, 2025 at 08:44:01AM -0700, Breno Leitao wrote:
> My UEFI machines with tegra210-quad consistently report "device reset
> failed". Investigation showed this isn't an actual failure
> - __device_reset() returns -ENOENT because ACPI has no "*_RST" method.
That's not the case, it's returning an error because there is no reset
controller discoverable via any mechanism. There's no specific handling
for ACPI here. It's also not clear that this is a false positive, the
driver did indeed fail to reset the device and especially for the error
handling case that seems like relevant information. At the very least
the changelog should be clarified.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-03-17 16:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 15:44 [PATCH 0/3] spi: tegra210-quad: Improve reset and tx failures Breno Leitao
2025-03-17 15:44 ` [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset() Breno Leitao
2025-03-17 16:45 ` Mark Brown [this message]
2025-03-17 16:56 ` Breno Leitao
2025-03-17 17:24 ` Mark Brown
2025-03-18 10:36 ` Breno Leitao
2025-03-18 12:48 ` Mark Brown
2025-03-18 17:02 ` Breno Leitao
2025-03-18 17:34 ` Mark Brown
2025-03-18 18:29 ` Breno Leitao
2025-03-18 18:32 ` Breno Leitao
2025-03-18 19:00 ` Arnd Bergmann
2025-03-18 19:13 ` Mark Brown
2025-03-18 20:07 ` Arnd Bergmann
2025-03-19 10:09 ` Breno Leitao
2025-03-19 18:26 ` Thierry Reding
2025-03-19 18:53 ` Breno Leitao
2025-03-21 12:40 ` Thierry Reding
2025-03-21 16:28 ` Breno Leitao
2025-03-24 13:17 ` Thierry Reding
2025-03-25 16:56 ` Breno Leitao
2025-03-25 17:05 ` Thierry Reding
2025-03-28 13:18 ` Breno Leitao
2025-03-19 13:11 ` Mark Brown
2025-03-18 18:35 ` Mark Brown
2025-03-18 19:08 ` Breno Leitao
2025-03-18 19:16 ` Mark Brown
2025-03-17 15:44 ` [PATCH 2/3] spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts Breno Leitao
2025-03-17 15:44 ` [PATCH 3/3] spi: tegra210-quad: add rate limiting and simplify timeout error message Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ffa8f5-6590-4602-853d-ceffed580f22@sirena.org.uk \
--to=broonie@debian.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-team@meta.com \
--cc=ldewangan@nvidia.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rmikey@meta.com \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox