From: Jon Hunter <jonathanh@nvidia.com>
To: Aaron Kling <webgeek1234@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Joseph Lo <josephl@nvidia.com>, Stephen Boyd <sboyd@kernel.org>,
Thierry Reding <treding@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] soc: tegra: fuse: speedo-tegra210: Update speedo ids
Date: Fri, 19 Sep 2025 10:55:24 +0100 [thread overview]
Message-ID: <5e1b09f0-7f4a-421c-b09f-4f95c1c6ec3b@nvidia.com> (raw)
In-Reply-To: <CALHNRZ_gNzCEOzcYBY4o5Hz-efS5b52K4uZqmw5ps5zEfKoOEw@mail.gmail.com>
On 18/09/2025 18:19, Aaron Kling wrote:
> On Thu, Sep 18, 2025 at 4:45 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>>
>>
>> On 04/09/2025 02:58, Aaron Kling via B4 Relay wrote:
>>> From: Aaron Kling <webgeek1234@gmail.com>
>>>
>>> Existing code only sets cpu and gpu speedo ids 0 and 1. The cpu dvfs
>>> code supports 11 ids and nouveau supports 5. This aligns with what the
>>> downstream vendor kernel supports. Align skus with the downstream list.
>>
>> Do you have a reference for the downstream kernel change you are
>> referring to? I have found this change [0]. However, this does not quite
>> align with what you have in this patch.
>
> This is based on L4T r32.7.6 [0], which builds up the list over
> several commits, so I can't link to just one. The first revision only
> added sku's that I had specifically verified. Mikko suggested to just
> import everything from downstream and to simplify the conditionals.
> And that's this revision.
...
> [0] https://nv-tegra.nvidia.com/r/plugins/gitiles/linux-4.9/+/refs/tags/tegra-l4t-r32.7.6_good/drivers/soc/tegra/fuse/speedo-tegra210.c#72
Thanks! I saw Mikko's comments on V2 and that makes sense. The problem I
have is that comparing this with the above, it is not clear that these
are equivalent. The above is using the 'a02' chip version for setting
the speedo IDs but this is using the speedo revision. Now it might turn
out this is equivalent, but it is not obvious to me. Ideally we would
end up with something similar to the above.
Jon
--
nvpublic
next prev parent reply other threads:[~2025-09-19 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 1:58 [PATCH v3] soc: tegra: fuse: speedo-tegra210: Update speedo ids Aaron Kling via B4 Relay
2025-09-18 3:18 ` Mikko Perttunen
2025-09-18 9:45 ` Jon Hunter
2025-09-18 17:19 ` Aaron Kling
2025-09-19 9:55 ` Jon Hunter [this message]
2025-09-22 17:16 ` Aaron Kling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e1b09f0-7f4a-421c-b09f-4f95c1c6ec3b@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox