* [PATCH] phy: tegra: xusb: Enable usb role switch attribute
@ 2022-09-21 11:25 Haotien Hsu
2022-09-24 7:17 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Haotien Hsu @ 2022-09-21 11:25 UTC (permalink / raw)
To: p.zabel
Cc: jckuo, kishon, vkoul, thierry.reding, jonathanh, linux-phy,
linux-tegra, linux-kernel, Wayne Chang, Haotien Hsu
From: Wayne Chang <waynec@nvidia.com>
This patch enables the usb-role-switch atrribute
to have the user-space check current device role
of otg cability ports
Signed-off-by: Wayne Chang <waynec@nvidia.com>
Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
---
drivers/phy/tegra/xusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index aa5237eacd29..220ab7719ade 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
struct usb_role_switch_desc role_sx_desc = {
.fwnode = dev_fwnode(&port->dev),
.set = tegra_xusb_role_sw_set,
+ .allow_userspace_control = true,
};
int err = 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] phy: tegra: xusb: Enable usb role switch attribute
2022-09-21 11:25 [PATCH] phy: tegra: xusb: Enable usb role switch attribute Haotien Hsu
@ 2022-09-24 7:17 ` Vinod Koul
2022-09-26 5:00 ` Haotien Hsu
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2022-09-24 7:17 UTC (permalink / raw)
To: Haotien Hsu
Cc: p.zabel, jckuo, kishon, thierry.reding, jonathanh, linux-phy,
linux-tegra, linux-kernel, Wayne Chang
On 21-09-22, 19:25, Haotien Hsu wrote:
> From: Wayne Chang <waynec@nvidia.com>
>
> This patch enables the usb-role-switch atrribute
> to have the user-space check current device role
> of otg cability ports
typo cability
You can use 72 chars for changelog rather than limiting at 50chars :-(
>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> ---
> drivers/phy/tegra/xusb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index aa5237eacd29..220ab7719ade 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
> struct usb_role_switch_desc role_sx_desc = {
> .fwnode = dev_fwnode(&port->dev),
> .set = tegra_xusb_role_sw_set,
> + .allow_userspace_control = true,
> };
> int err = 0;
>
> --
> 2.25.1
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy: tegra: xusb: Enable usb role switch attribute
2022-09-24 7:17 ` Vinod Koul
@ 2022-09-26 5:00 ` Haotien Hsu
0 siblings, 0 replies; 3+ messages in thread
From: Haotien Hsu @ 2022-09-26 5:00 UTC (permalink / raw)
To: Vinod Koul
Cc: p.zabel, jckuo, kishon, thierry.reding, jonathanh, linux-phy,
linux-tegra, linux-kernel, Wayne Chang
On 9/24/22 15:17, Vinod Koul wrote:
> On 21-09-22, 19:25, Haotien Hsu wrote:
>> From: Wayne Chang <waynec@nvidia.com>
>>
>> This patch enables the usb-role-switch atrribute
>> to have the user-space check current device role
>> of otg cability ports
>
> typo cability
>
>
> You can use 72 chars for changelog rather than limiting at 50chars :-(
>
Sorry for the typo and bad format.
I will resend this patch.
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
>> ---
>> drivers/phy/tegra/xusb.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
>> index aa5237eacd29..220ab7719ade 100644
>> --- a/drivers/phy/tegra/xusb.c
>> +++ b/drivers/phy/tegra/xusb.c
>> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
>> struct usb_role_switch_desc role_sx_desc = {
>> .fwnode = dev_fwnode(&port->dev),
>> .set = tegra_xusb_role_sw_set,
>> + .allow_userspace_control = true,
>> };
>> int err = 0;
>>
>> --
>> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-26 5:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-21 11:25 [PATCH] phy: tegra: xusb: Enable usb role switch attribute Haotien Hsu
2022-09-24 7:17 ` Vinod Koul
2022-09-26 5:00 ` Haotien Hsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox