From: Thierry Reding <thierry.reding@gmail.com>
To: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jonathanh@nvidia.com, arnd@arndb.de, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: smaug: Add EMC frequency change tables
Date: Wed, 5 Apr 2023 15:18:23 +0200 [thread overview]
Message-ID: <ZC11H7mXfHX_mGXh@orome> (raw)
In-Reply-To: <20230319194255.124589-1-diogo.ivo@tecnico.ulisboa.pt>
[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]
On Sun, Mar 19, 2023 at 07:42:55PM +0000, Diogo Ivo wrote:
> Add the reserved-memory regions of the nominal and derated tables setup by
> the bootloader so that the EMC frequency change code can access them.
>
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> index 709f3f417a19..a74826ae97b4 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> @@ -30,6 +30,22 @@ memory {
> reg = <0x0 0x80000000 0x0 0xc0000000>;
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + nominal: emc-table@f67cc000 {
> + compatible = "nvidia,tegra210-emc-table";
> + reg = <0x0 0xf67cc000 0x0 0xbea0>;
> + };
> +
> + derated: emc-table@f67d7ea0 {
> + compatible = "nvidia,tegra210-emc-table";
> + reg = <0x0 0xf67d7ea0 0x0 0xbea0>;
> + };
> + };
> +
These tables are typically generated by the firmware/bootloader at
runtime. Often they'll use heap allocations for these, so the addresses
are not guaranteed to be static.
Can you share a few details about what set of components you've used to
set this up? If we add these we want to be as specific as possible that
people use exactly the same set of firmware files.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-05 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 19:42 [PATCH] arm64: dts: smaug: Add EMC frequency change tables Diogo Ivo
2023-03-20 6:50 ` Krzysztof Kozlowski
2023-03-20 11:34 ` Diogo Ivo
2023-03-20 11:37 ` Krzysztof Kozlowski
2023-04-05 13:18 ` Thierry Reding [this message]
2023-04-10 9:17 ` Diogo Ivo
2023-07-10 15:32 ` Thierry Reding
2023-07-10 17:46 ` Diogo Ivo
2023-06-19 8:55 ` Diogo Ivo
2023-07-10 13:18 ` Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC11H7mXfHX_mGXh@orome \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox