Re: [PATCH] arm64: dts: smaug: Add EMC frequency change tables

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 19/03/2023 20:42, Diogo Ivo wrote:
> Add the reserved-memory regions of the nominal and derated tables setup by
> the bootloader so that the EMC frequency change code can access them.
> 
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> ---
>  arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> index 709f3f417a19..a74826ae97b4 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> @@ -30,6 +30,22 @@ memory {
>  		reg = <0x0 0x80000000 0x0 0xc0000000>;
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		nominal: emc-table@f67cc000 {
> +			compatible = "nvidia,tegra210-emc-table";
> +			reg = <0x0 0xf67cc000 0x0 0xbea0>;
> +		};
> +
> +		derated: emc-table@f67d7ea0 {
> +			compatible = "nvidia,tegra210-emc-table";
> +			reg = <0x0 0xf67d7ea0 0x0 0xbea0>;
> +		};
> +	};
> +
>  	host1x@50000000 {
>  		dc@54200000 {
>  			status = "okay";
> @@ -1735,6 +1751,11 @@ pmc@7000e400 {
>  		status = "okay";
>  	};
>  
> +	emc: external-memory-controller@7001b000 {

Node names should be generic, so memory-controller.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Check your code for warnings (dtc, dtbs_check). Node with unit address
requires reg or ranges.

Best regards,
Krzysztof