From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
thierry.reding@gmail.com, jonathanh@nvidia.com, arnd@arndb.de,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: smaug: Add EMC frequency change tables
Date: Mon, 20 Mar 2023 12:37:43 +0100 [thread overview]
Message-ID: <b33da2e7-47df-ed07-50ba-a197c8b94457@linaro.org> (raw)
In-Reply-To: <20230320113403.4oyp7anjuh7azy6q@wslaptop>
On 20/03/2023 12:34, Diogo Ivo wrote:
> On Mon, Mar 20, 2023 at 07:50:27AM +0100, Krzysztof Kozlowski wrote:
>> On 19/03/2023 20:42, Diogo Ivo wrote:
>>> + emc: external-memory-controller@7001b000 {
>>
>> Node names should be generic, so memory-controller.
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>
>> Check your code for warnings (dtc, dtbs_check). Node with unit address
>> requires reg or ranges.
>>
>> Best regards,
>> Krzysztof
>
>
> Hello,
>
> The external-memory-controller node is declared in tegra210.dtsi, so
> here I am just adding more properties to it.
Ah, ok, apologies then for false alarm. This Tegra notation of extending
existing nodes is crazy confusing...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-20 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 19:42 [PATCH] arm64: dts: smaug: Add EMC frequency change tables Diogo Ivo
2023-03-20 6:50 ` Krzysztof Kozlowski
2023-03-20 11:34 ` Diogo Ivo
2023-03-20 11:37 ` Krzysztof Kozlowski [this message]
2023-04-05 13:18 ` Thierry Reding
2023-04-10 9:17 ` Diogo Ivo
2023-07-10 15:32 ` Thierry Reding
2023-07-10 17:46 ` Diogo Ivo
2023-06-19 8:55 ` Diogo Ivo
2023-07-10 13:18 ` Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b33da2e7-47df-ed07-50ba-a197c8b94457@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox