* [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor @ 2026-08-17 14:32 Thierry Reding 2026-08-17 14:41 ` Jon Hunter 0 siblings, 1 reply; 5+ messages in thread From: Thierry Reding @ 2026-08-17 14:32 UTC (permalink / raw) To: Thierry Reding; +Cc: Jon Hunter, linux-tegra From: Thierry Reding <treding@nvidia.com> The built-in RTC is mostly useful for testing suspend/resume cycles. Signed-off-by: Thierry Reding <treding@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi index c4ba3322ed9a..113ecf297378 100644 --- a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi @@ -13,6 +13,12 @@ chosen { stdout-path = "serial0:115200n8"; }; + bus@0 { + rtc@c2c0000 { + status = "okay"; + }; + }; + gpio-keys { compatible = "gpio-keys"; -- 2.55.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor 2026-08-17 14:32 [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor Thierry Reding @ 2026-08-17 14:41 ` Jon Hunter 2026-08-18 10:54 ` Thierry Reding 0 siblings, 1 reply; 5+ messages in thread From: Jon Hunter @ 2026-08-17 14:41 UTC (permalink / raw) To: Thierry Reding; +Cc: linux-tegra On 17/08/2026 15:32, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The built-in RTC is mostly useful for testing suspend/resume cycles. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > index c4ba3322ed9a..113ecf297378 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > @@ -13,6 +13,12 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + bus@0 { > + rtc@c2c0000 { > + status = "okay"; > + }; > + }; > + Any reason we should not just enable in tegra264.dtsi by default? I see that we do that for tegra234. Jon -- nvpublic ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor 2026-08-17 14:41 ` Jon Hunter @ 2026-08-18 10:54 ` Thierry Reding 2026-09-11 14:48 ` Jon Hunter 0 siblings, 1 reply; 5+ messages in thread From: Thierry Reding @ 2026-08-18 10:54 UTC (permalink / raw) To: Jon Hunter; +Cc: linux-tegra [-- Attachment #1: Type: text/plain, Size: 1638 bytes --] On Mon, Aug 17, 2026 at 03:41:31PM +0100, Jon Hunter wrote: > > On 17/08/2026 15:32, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > The built-in RTC is mostly useful for testing suspend/resume cycles. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > > index c4ba3322ed9a..113ecf297378 100644 > > --- a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > > +++ b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > > @@ -13,6 +13,12 @@ chosen { > > stdout-path = "serial0:115200n8"; > > }; > > + bus@0 { > > + rtc@c2c0000 { > > + status = "okay"; > > + }; > > + }; > > + > > > Any reason we should not just enable in tegra264.dtsi by default? I see that > we do that for tegra234. This is more of a development type of option and not everybody may want to have it enabled, especially since it's not always hooked up to do anything useful. We commonly use it on the devkit for suspend/resume testing, so it's useful there, but even then there's usually another RTC on a PMIC or something that's considered the primary one. So in production I suspect people may not want to enable the built-in RTC. If we enabled it by default, then people would have to explicitly disable it again. I don't feel very strongly either way, and I could easily be swayed. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor 2026-08-18 10:54 ` Thierry Reding @ 2026-09-11 14:48 ` Jon Hunter 2026-09-18 12:36 ` Thierry Reding 0 siblings, 1 reply; 5+ messages in thread From: Jon Hunter @ 2026-09-11 14:48 UTC (permalink / raw) To: Thierry Reding; +Cc: linux-tegra On 18/08/2026 11:54, Thierry Reding wrote: > On Mon, Aug 17, 2026 at 03:41:31PM +0100, Jon Hunter wrote: >> >> On 17/08/2026 15:32, Thierry Reding wrote: >>> From: Thierry Reding <treding@nvidia.com> >>> >>> The built-in RTC is mostly useful for testing suspend/resume cycles. >>> >>> Signed-off-by: Thierry Reding <treding@nvidia.com> >>> --- >>> arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi >>> index c4ba3322ed9a..113ecf297378 100644 >>> --- a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi >>> +++ b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi >>> @@ -13,6 +13,12 @@ chosen { >>> stdout-path = "serial0:115200n8"; >>> }; >>> + bus@0 { >>> + rtc@c2c0000 { >>> + status = "okay"; >>> + }; >>> + }; >>> + >> >> >> Any reason we should not just enable in tegra264.dtsi by default? I see that >> we do that for tegra234. > > This is more of a development type of option and not everybody may want > to have it enabled, especially since it's not always hooked up to do > anything useful. We commonly use it on the devkit for suspend/resume > testing, so it's useful there, but even then there's usually another RTC > on a PMIC or something that's considered the primary one. > > So in production I suspect people may not want to enable the built-in > RTC. If we enabled it by default, then people would have to explicitly > disable it again. > > I don't feel very strongly either way, and I could easily be swayed. I would be good to get this added. I don't have strong feelings either way. So ... Tested-by: Jon Hunter <jonathanh@nvidia.com> Acked-by: Jon Hunter <jonathanh@nvidia.com> Thanks! Jon -- nvpublic ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor 2026-09-11 14:48 ` Jon Hunter @ 2026-09-18 12:36 ` Thierry Reding 0 siblings, 0 replies; 5+ messages in thread From: Thierry Reding @ 2026-09-18 12:36 UTC (permalink / raw) To: Jon Hunter; +Cc: linux-tegra [-- Attachment #1: Type: text/plain, Size: 2129 bytes --] On Fri, Sep 11, 2026 at 03:48:19PM +0100, Jon Hunter wrote: > > On 18/08/2026 11:54, Thierry Reding wrote: > > On Mon, Aug 17, 2026 at 03:41:31PM +0100, Jon Hunter wrote: > > > > > > On 17/08/2026 15:32, Thierry Reding wrote: > > > > From: Thierry Reding <treding@nvidia.com> > > > > > > > > The built-in RTC is mostly useful for testing suspend/resume cycles. > > > > > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > > > --- > > > > arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > > > > index c4ba3322ed9a..113ecf297378 100644 > > > > --- a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > > > > +++ b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi > > > > @@ -13,6 +13,12 @@ chosen { > > > > stdout-path = "serial0:115200n8"; > > > > }; > > > > + bus@0 { > > > > + rtc@c2c0000 { > > > > + status = "okay"; > > > > + }; > > > > + }; > > > > + > > > > > > > > > Any reason we should not just enable in tegra264.dtsi by default? I see that > > > we do that for tegra234. > > > > This is more of a development type of option and not everybody may want > > to have it enabled, especially since it's not always hooked up to do > > anything useful. We commonly use it on the devkit for suspend/resume > > testing, so it's useful there, but even then there's usually another RTC > > on a PMIC or something that's considered the primary one. > > > > So in production I suspect people may not want to enable the built-in > > RTC. If we enabled it by default, then people would have to explicitly > > disable it again. > > > > I don't feel very strongly either way, and I could easily be swayed. > > I would be good to get this added. I don't have strong feelings either > way. So ... > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Acked-by: Jon Hunter <jonathanh@nvidia.com> Applied, thanks. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-18 12:36 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-08-17 14:32 [PATCH] arm64: tegra: Enable built-in RTC on Jetson AGX Thor Thierry Reding 2026-08-17 14:41 ` Jon Hunter 2026-08-18 10:54 ` Thierry Reding 2026-09-11 14:48 ` Jon Hunter 2026-09-18 12:36 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox