* [PATCH] arm64: tegra: Move HDA into the correct bus
@ 2025-11-04 13:23 Thierry Reding
2025-11-04 13:34 ` Jon Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2025-11-04 13:23 UTC (permalink / raw)
To: Thierry Reding; +Cc: sheetal, linux-tegra
From: Thierry Reding <treding@nvidia.com>
HDA is part of the DISP_USB bus, so move it into that and drop the
address prefix accordingly.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../arm64/boot/dts/nvidia/tegra264-p3971.dtsi | 4 ++-
arch/arm64/boot/dts/nvidia/tegra264.dtsi | 32 +++++++++----------
2 files changed, 19 insertions(+), 17 deletions(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p3971.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p3971.dtsi
index 1fcfac2066ae..b1bd4ee7aee3 100644
--- a/arch/arm64/boot/dts/nvidia/tegra264-p3971.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra264-p3971.dtsi
@@ -29,8 +29,10 @@ interrupt-controller@9960000 {
status = "okay";
};
};
+ };
- hda@88090b0000 {
+ bus@8800000000 {
+ hda@90b0000 {
nvidia,model = "NVIDIA Jetson Thor AGX HDA";
status = "okay";
};
diff --git a/arch/arm64/boot/dts/nvidia/tegra264.dtsi b/arch/arm64/boot/dts/nvidia/tegra264.dtsi
index c66ea12ef5a3..f137565da804 100644
--- a/arch/arm64/boot/dts/nvidia/tegra264.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra264.dtsi
@@ -3347,22 +3347,6 @@ pmc: pmc@c800000 {
#interrupt-cells = <2>;
interrupt-controller;
};
-
- hda@88090b0000 {
- compatible = "nvidia,tegra264-hda";
- reg = <0x88 0x90b0000 0x0 0x10000>;
- interrupts = <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&bpmp TEGRA264_CLK_AZA_2XBIT>;
- clock-names = "hda";
- resets = <&bpmp TEGRA264_RESET_HDA>,
- <&bpmp TEGRA264_RESET_HDACODEC>;
- reset-names = "hda", "hda2codec_2x";
- interconnects = <&mc TEGRA264_MEMORY_CLIENT_HDAR &emc>,
- <&mc TEGRA264_MEMORY_CLIENT_HDAW &emc>;
- interconnect-names = "dma-mem", "write";
- iommus = <&smmu3 TEGRA264_SID_HDA>;
- status = "disabled";
- };
};
/* TOP_MMIO */
@@ -3716,6 +3700,22 @@ smmu3: iommu@6000000 {
#iommu-cells = <1>;
dma-coherent;
};
+
+ hda@90b0000 {
+ compatible = "nvidia,tegra264-hda";
+ reg = <0x0 0x90b0000 0x0 0x10000>;
+ interrupts = <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&bpmp TEGRA264_CLK_AZA_2XBIT>;
+ clock-names = "hda";
+ resets = <&bpmp TEGRA264_RESET_HDA>,
+ <&bpmp TEGRA264_RESET_HDACODEC>;
+ reset-names = "hda", "hda2codec_2x";
+ interconnects = <&mc TEGRA264_MEMORY_CLIENT_HDAR &emc>,
+ <&mc TEGRA264_MEMORY_CLIENT_HDAW &emc>;
+ interconnect-names = "dma-mem", "write";
+ iommus = <&smmu3 TEGRA264_SID_HDA>;
+ status = "disabled";
+ };
};
/* UPHY MMIO */
--
2.51.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: tegra: Move HDA into the correct bus
2025-11-04 13:23 [PATCH] arm64: tegra: Move HDA into the correct bus Thierry Reding
@ 2025-11-04 13:34 ` Jon Hunter
2025-11-04 13:44 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Jon Hunter @ 2025-11-04 13:34 UTC (permalink / raw)
To: Thierry Reding; +Cc: sheetal, linux-tegra
On 04/11/2025 13:23, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> HDA is part of the DISP_USB bus, so move it into that and drop the
> address prefix accordingly.
>
Is there a fixes-tag we need for this?
Otherwise ...
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Jon
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../arm64/boot/dts/nvidia/tegra264-p3971.dtsi | 4 ++-
> arch/arm64/boot/dts/nvidia/tegra264.dtsi | 32 +++++++++----------
> 2 files changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p3971.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p3971.dtsi
> index 1fcfac2066ae..b1bd4ee7aee3 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra264-p3971.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra264-p3971.dtsi
> @@ -29,8 +29,10 @@ interrupt-controller@9960000 {
> status = "okay";
> };
> };
> + };
>
> - hda@88090b0000 {
> + bus@8800000000 {
> + hda@90b0000 {
> nvidia,model = "NVIDIA Jetson Thor AGX HDA";
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/nvidia/tegra264.dtsi b/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> index c66ea12ef5a3..f137565da804 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> @@ -3347,22 +3347,6 @@ pmc: pmc@c800000 {
> #interrupt-cells = <2>;
> interrupt-controller;
> };
> -
> - hda@88090b0000 {
> - compatible = "nvidia,tegra264-hda";
> - reg = <0x88 0x90b0000 0x0 0x10000>;
> - interrupts = <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&bpmp TEGRA264_CLK_AZA_2XBIT>;
> - clock-names = "hda";
> - resets = <&bpmp TEGRA264_RESET_HDA>,
> - <&bpmp TEGRA264_RESET_HDACODEC>;
> - reset-names = "hda", "hda2codec_2x";
> - interconnects = <&mc TEGRA264_MEMORY_CLIENT_HDAR &emc>,
> - <&mc TEGRA264_MEMORY_CLIENT_HDAW &emc>;
> - interconnect-names = "dma-mem", "write";
> - iommus = <&smmu3 TEGRA264_SID_HDA>;
> - status = "disabled";
> - };
> };
>
> /* TOP_MMIO */
> @@ -3716,6 +3700,22 @@ smmu3: iommu@6000000 {
> #iommu-cells = <1>;
> dma-coherent;
> };
> +
> + hda@90b0000 {
> + compatible = "nvidia,tegra264-hda";
> + reg = <0x0 0x90b0000 0x0 0x10000>;
> + interrupts = <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&bpmp TEGRA264_CLK_AZA_2XBIT>;
> + clock-names = "hda";
> + resets = <&bpmp TEGRA264_RESET_HDA>,
> + <&bpmp TEGRA264_RESET_HDACODEC>;
> + reset-names = "hda", "hda2codec_2x";
> + interconnects = <&mc TEGRA264_MEMORY_CLIENT_HDAR &emc>,
> + <&mc TEGRA264_MEMORY_CLIENT_HDAW &emc>;
> + interconnect-names = "dma-mem", "write";
> + iommus = <&smmu3 TEGRA264_SID_HDA>;
> + status = "disabled";
> + };
> };
>
> /* UPHY MMIO */
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: tegra: Move HDA into the correct bus
2025-11-04 13:34 ` Jon Hunter
@ 2025-11-04 13:44 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2025-11-04 13:44 UTC (permalink / raw)
To: Jon Hunter; +Cc: sheetal, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On Tue, Nov 04, 2025 at 01:34:38PM +0000, Jon Hunter wrote:
>
>
> On 04/11/2025 13:23, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > HDA is part of the DISP_USB bus, so move it into that and drop the
> > address prefix accordingly.
> >
>
> Is there a fixes-tag we need for this?
>
> Otherwise ...
>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>
I think it'd be good if Sheetal could review and test it, at which point
I could equally well merge it into her initial patch that added this,
which is still very close to the top of the arm64/dt branch. Even if it
remains a standalone patch, no need for a Fixes: tag since it'll all go
into the same version anyway and doesn't need to be backported.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-04 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 13:23 [PATCH] arm64: tegra: Move HDA into the correct bus Thierry Reding
2025-11-04 13:34 ` Jon Hunter
2025-11-04 13:44 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox