From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>, Chao Liu <chao.liu@processmission.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] rv/rtapp: Add wakeup monitor
Date: Wed, 22 Jul 2026 11:36:10 +0200 [thread overview]
Message-ID: <1fe191ba66ae668b4635e2dd18b3e6c3b3c0090d.camel@redhat.com> (raw)
In-Reply-To: <87y0f3wjuk.fsf@yellow.woof>
On Wed, 2026-07-22 at 09:42 +0200, Nam Cao wrote:
> Chao Liu <chao.liu@processmission.com> writes:
> > > +static void handle_sched_waking(void *data, struct task_struct *task)
> > > +{
> > > + if (in_task()) {
> > > + if (current->prio > task->prio)
> > > + ltl_atom_pulse(task, LTL_WOKEN_BY_LOWER_PRIO,
> > > true);
> >
> > The implementation also reports wakeups from softirq context through
> > WOKEN_BY_SOFTIRQ:
> >
> > > + } else if (in_serving_softirq()) {
> > > + ltl_atom_pulse(task, LTL_WOKEN_BY_SOFTIRQ, true);
> > > + }
> >
> > Should this description mention softirq wakeups as well?
>
> Technically, on RT kernel, softirq is a SCHED_OTHER task. On !RT kernel,
> softirq can also be executed as a SCHED_OTHER task, which is the cause
> for concern.
>
> But explicitly mentioning softirq does not hurt, I wouldn't oppose that.
Sounds good to me. So as far as I understand, this change is going to go through
a separate patch right?
I'm considering this series final.
Thanks,
Gabriele
prev parent reply other threads:[~2026-07-22 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 7:21 [PATCH v2 0/4] rv: rtapp monitor update Nam Cao
2026-06-19 7:21 ` [PATCH v2 1/4] rv/rtapp/sleep: Make the error more informative for user Nam Cao
2026-07-01 12:26 ` Gabriele Monaco
2026-07-01 12:34 ` Gabriele Monaco
2026-06-19 7:21 ` [PATCH v2 2/4] rv/rtapp/sleep: Update nanosleep rule Nam Cao
2026-07-01 12:29 ` Gabriele Monaco
2026-06-19 7:21 ` [PATCH v2 3/4] rv/rtapp/sleep: Stop monitoring kernel threads Nam Cao
2026-07-01 13:02 ` Gabriele Monaco
2026-06-19 7:21 ` [PATCH v2 4/4] rv/rtapp: Add wakeup monitor Nam Cao
2026-07-01 13:11 ` Gabriele Monaco
2026-07-02 7:25 ` Nam Cao
2026-07-02 12:12 ` Gabriele Monaco
2026-07-22 4:45 ` Chao Liu
2026-07-22 7:42 ` Nam Cao
2026-07-22 9:29 ` Chao Liu
2026-07-22 9:36 ` Gabriele Monaco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe191ba66ae668b4635e2dd18b3e6c3b3c0090d.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=chao.liu@processmission.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox