* [PATCH] tracing: Fix #if CONFIG_MODULES to #ifdef CONFIG_MODULES
@ 2025-01-20 17:57 Steven Rostedt
2025-01-20 18:09 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2025-01-20 17:57 UTC (permalink / raw)
To: LKML, Linux Trace Kernel
Cc: Masami Hiramatsu, Mathieu Desnoyers, Linus Torvalds,
kernel test robot
From: Steven Rostedt <rostedt@goodmis.org>
A typo was introduced when adding the ":mod:" command that did
a "#if CONFIG_MODULES" instead of a "#ifdef CONFIG_MODULES".
Fix it.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501110319.xY9ltUxL-lkp@intel.com/
Fixes: b355247df104e ("tracing: Cache ":mod:" events for modules not loaded yet")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/trace/trace_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index f762e554fad4..bb1406719c3f 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -857,7 +857,7 @@ static int ftrace_event_enable_disable(struct trace_event_file *file,
return __ftrace_event_enable_disable(file, enable, 0);
}
-#if CONFIG_MODULES
+#ifdef CONFIG_MODULES
struct event_mod_load {
struct list_head list;
char *module;
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tracing: Fix #if CONFIG_MODULES to #ifdef CONFIG_MODULES
2025-01-20 17:57 [PATCH] tracing: Fix #if CONFIG_MODULES to #ifdef CONFIG_MODULES Steven Rostedt
@ 2025-01-20 18:09 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2025-01-20 18:09 UTC (permalink / raw)
To: LKML, Linux Trace Kernel
Cc: Masami Hiramatsu, Mathieu Desnoyers, Linus Torvalds,
kernel test robot
On Mon, 20 Jan 2025 12:57:45 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> A typo was introduced when adding the ":mod:" command that did
> a "#if CONFIG_MODULES" instead of a "#ifdef CONFIG_MODULES".
> Fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501110319.xY9ltUxL-lkp@intel.com/
Cut and paste error. Wrong closes: Should have been:
Closes: https://lore.kernel.org/oe-kbuild-all/202501190121.E2CIJuUj-lkp@intel.com/
-- Steve
> Fixes: b355247df104e ("tracing: Cache ":mod:" events for modules not loaded yet")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> kernel/trace/trace_events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index f762e554fad4..bb1406719c3f 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -857,7 +857,7 @@ static int ftrace_event_enable_disable(struct trace_event_file *file,
> return __ftrace_event_enable_disable(file, enable, 0);
> }
>
> -#if CONFIG_MODULES
> +#ifdef CONFIG_MODULES
> struct event_mod_load {
> struct list_head list;
> char *module;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-20 18:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-20 17:57 [PATCH] tracing: Fix #if CONFIG_MODULES to #ifdef CONFIG_MODULES Steven Rostedt
2025-01-20 18:09 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox