From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Vincent Donnefort <vdonnefort@google.com>
Subject: Re: [PATCH] tracing: Do not allow mmap() of persistent ring buffer
Date: Thu, 13 Feb 2025 21:21:47 -0500 [thread overview]
Message-ID: <20250213212147.6511b235@gandalf.local.home> (raw)
In-Reply-To: <20250214110722.7eaf35b42c4858e6b74500f7@kernel.org>
On Fri, 14 Feb 2025 11:07:22 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> This may be good for fixing crash short term but may not allow us to read the
> subbufs which is read right before crash. Can we also add an option to reset
> the read pointer in the previous boot for the persistent ring buffer?
I'm not sure what you mean here.
Note, this is just for mmapping the buffers. Currently we never tried it as
if we did, it would have crashed. But this does not affect normal reads.
-- Steve
next prev parent reply other threads:[~2025-02-14 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 23:07 [PATCH] tracing: Do not allow mmap() of persistent ring buffer Steven Rostedt
2025-02-14 2:07 ` Masami Hiramatsu
2025-02-14 2:21 ` Steven Rostedt [this message]
2025-02-14 7:13 ` Masami Hiramatsu
2025-02-14 12:07 ` Steven Rostedt
2025-02-14 14:36 ` Masami Hiramatsu
2025-02-14 14:59 ` Steven Rostedt
2025-02-15 15:37 ` Masami Hiramatsu
2025-02-15 16:21 ` Steven Rostedt
2025-02-15 16:45 ` Steven Rostedt
2025-02-18 15:14 ` Masami Hiramatsu
2025-02-18 15:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213212147.6511b235@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox