From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Vincent Donnefort <vdonnefort@google.com>
Subject: Re: [PATCH] tracing: Do not allow mmap() of persistent ring buffer
Date: Fri, 14 Feb 2025 09:59:43 -0500 [thread overview]
Message-ID: <20250214095943.178501fa@gandalf.local.home> (raw)
In-Reply-To: <20250214233613.bde0638f393186f56f0b30eb@kernel.org>
On Fri, 14 Feb 2025 23:36:13 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> >
> > It's not supported. If you try it, it will crash. This prevents reading via
> > mmap() on a boot buffer. I don't know what you are asking. Once this patch
> > is applied, mmap() will always fail on the boot buffer before or after you
> > start it.
>
> Hmm, I meant it is supported for other non-persisten ring buffer, isn't it?
Correct. It is supported in other buffers, but it just isn't supported in
the persistent one.
This patch only disables mmap if it's trying to mmap a persistent one.
I guess I don't understand your concern.
-- Steve
next prev parent reply other threads:[~2025-02-14 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 23:07 [PATCH] tracing: Do not allow mmap() of persistent ring buffer Steven Rostedt
2025-02-14 2:07 ` Masami Hiramatsu
2025-02-14 2:21 ` Steven Rostedt
2025-02-14 7:13 ` Masami Hiramatsu
2025-02-14 12:07 ` Steven Rostedt
2025-02-14 14:36 ` Masami Hiramatsu
2025-02-14 14:59 ` Steven Rostedt [this message]
2025-02-15 15:37 ` Masami Hiramatsu
2025-02-15 16:21 ` Steven Rostedt
2025-02-15 16:45 ` Steven Rostedt
2025-02-18 15:14 ` Masami Hiramatsu
2025-02-18 15:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214095943.178501fa@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox