From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Vincent Donnefort <vdonnefort@google.com>
Subject: Re: [PATCH] tracing: Do not allow mmap() of persistent ring buffer
Date: Sat, 15 Feb 2025 11:21:53 -0500 [thread overview]
Message-ID: <20250215112153.55e56284@batman.local.home> (raw)
In-Reply-To: <20250216003702.eef00d543ebbc3b16140ed9c@kernel.org>
On Sun, 16 Feb 2025 00:37:02 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> My concern is related to the fixes policy. If this is a "fix", we will
> backport the new "disables mmap on persistent ring buffer" limitation
> to the stable kernel (that was not documented previously.)
>
> However, from the user point of view, "mmap() ring buffers" is already
> supported (although it did not work on stable kernel for now). Thus I think
> the "Fix" is expected as "fixing mmap() persistent ring buffer".
This only disables mmapping of the persistent ring buffer. Other ring
buffers can be mapped. We never supported mmapping the persistent ring
buffer. Even in stable kernels, if you mmap it, it will crash just like
it does now. Thus, this doesn't cause any regressions. It's a fix even
for stable kernels.
Or did the virt_to_page() change recently where that wasn't the case?
-- Steve
next prev parent reply other threads:[~2025-02-15 16:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 23:07 [PATCH] tracing: Do not allow mmap() of persistent ring buffer Steven Rostedt
2025-02-14 2:07 ` Masami Hiramatsu
2025-02-14 2:21 ` Steven Rostedt
2025-02-14 7:13 ` Masami Hiramatsu
2025-02-14 12:07 ` Steven Rostedt
2025-02-14 14:36 ` Masami Hiramatsu
2025-02-14 14:59 ` Steven Rostedt
2025-02-15 15:37 ` Masami Hiramatsu
2025-02-15 16:21 ` Steven Rostedt [this message]
2025-02-15 16:45 ` Steven Rostedt
2025-02-18 15:14 ` Masami Hiramatsu
2025-02-18 15:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250215112153.55e56284@batman.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox