Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Brian Norris <briannorris@chromium.org>
Cc: sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
	linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
Date: Tue, 17 Nov 2026 16:10:11 -0500	[thread overview]
Message-ID: <20261117161011.59101930@gandalf.local.home> (raw)
In-Reply-To: <avy6nTb0ccqNNnOo@google.com>

On Tue, 17 Nov 2026 12:35:41 -0800
Brian Norris <briannorris@chromium.org> wrote:

> On Tue, Nov 17, 2026 at 02:23:10PM -0500, Steven Rostedt wrote:
> > On Tue, 17 Nov 2026 14:22:03 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> > As it doesn't need to be visible let's still have:  
> 
> What's wrong with visible? Hiding it is part of the confusion, because
> it disappears when you select something else, even though it's still
> effectively enabled.

Well, one thing, it's precedence. But another is that you can only deselect
it if everything else is not selected.

> 
> Personally, I think it would be nicer if we could eliminate the separate
> ENABLE_DEFAULT_TRACERS (or ENABLE_EVENTS or whatever you want to call
> it) and make CONFIG_EVENT_TRACING:

I think that may have been the reason for the craziness to begin with. I do
remember struggling with circular dependencies.

> 
> 1) user-configurable and
> 2) 'select'ed (or otherwise forced to =y) when something else truly
>    requires it
> 
> That would make it clearer what's happening, IMO.
> 
> But I'm not sure off the top of my head what the best way to do that in
> Kconfig is, without introducing odd circular dependencies or other
> issues, and I also don't know how much more time I want to spend on it.
> 
> I'm open to ideas, or I'll let it sit/marinate until I have more time.

I'm in no rush ;-)

-- Steve

  reply	other threads:[~2026-11-17 21:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
2026-11-16 22:58 ` sashiko-bot
2026-11-17 13:55   ` Steven Rostedt
2026-11-17 18:23     ` Brian Norris
2026-11-17 18:36       ` sashiko-bot
2026-11-17 18:42         ` Brian Norris
2026-11-17 19:22       ` Steven Rostedt
2026-11-17 19:23         ` Steven Rostedt
2026-11-17 20:35           ` Brian Norris
2026-11-17 21:10             ` Steven Rostedt [this message]
2026-11-17 21:41               ` Brian Norris
2026-11-17 13:53 ` Steven Rostedt
2026-11-17 17:45   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117161011.59101930@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=briannorris@chromium.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox