From: Sasha Levin <sashal@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: Vincent Donnefort <vdonnefort@google.com>,
stable@vger.kernel.org, rostedt@goodmis.org, mhiramat@kernel.org,
linux-trace-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, kernel-team@android.com,
linux-kernel@vger.kernel.org
Subject: Re: STABLE REQ: [PATCH v5 06/10] tracing: Fix subbuf resize races with trace_pipe_raw readers\
Date: Thu, 3 Sep 2026 08:44:05 -0400 [thread overview]
Message-ID: <aplrlQbTRxAxMsAF@laps> (raw)
In-Reply-To: <20260903123455.GS2133376@google.com>
On Thu, Sep 03, 2026 at 01:34:55PM +0100, Lee Jones wrote:
>On Thu, 03 Sep 2026, Vincent Donnefort wrote:
>
>> On Wed, Sep 02, 2026 at 06:14:05PM -0400, Sasha Levin wrote:
>> > > Concurrent subbuffer resizes may crash trace_pipe_raw readers or leak
>> > > uninitialized memory to userspace due to stale size values.
>> > >
>> > > Fixes: bce761d75745 ("ring-buffer: Read and write to ring buffers with custom sub buffer size")
>> > > Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
>> > >
>> > > Not sure if this is the latest version or not?
>> > >
>> > > I see review comments, but no v6. Anyway, no matter, it'll do.
>> >
>> > Queued for 7.2, thanks.
>> >
>> > --
>> > Thanks,
>> > Sasha
>>
>> This isn't the last version of this patch, I have just posted a v9 [1] and
>> Steven hasn't reviewed it yet.
>>
>> [1] https://lore.kernel.org/all/20260901155445.1475405-3-vdonnefort@google.com/
>
>The confusion is mine to own. I responded to the wrong patch mail, sorry!
>
> `ring-buffer: Fix subbuf resize race with ring buffer readers`
>
>Which is in Mainline with the immutable SHA 8a5f63637890. My assumption
>is that Sasha queued the correct commit or the tools would have
>complained loudly.
Indeed, sorry for the confusion! I've queued 8a5f63637890 ("ring-buffer: Fix
subbuf resize race with ring buffer readers") for 7.2.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-09-03 12:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 13:11 [PATCH v5 00/10] ring-buffer: Fixes for subbuf resizing and persistent buffers Vincent Donnefort
2026-08-13 13:11 ` [PATCH v5 01/10] ring-buffer: Free cpu_buffer::free_page with subbuf_order Vincent Donnefort
2026-08-13 13:54 ` sashiko-bot
2026-08-13 15:49 ` Masami Hiramatsu
2026-08-13 16:02 ` Vincent Donnefort
2026-08-13 16:03 ` Vincent Donnefort
2026-08-13 16:18 ` Masami Hiramatsu
2026-08-13 13:11 ` [PATCH v5 02/10] ring-buffer: Hold cpu_buffer::lock when resizing a subbuf Vincent Donnefort
2026-08-13 14:01 ` sashiko-bot
2026-08-13 13:11 ` [PATCH v5 03/10] ring-buffer: Make cpu_buffer::free_page a buffer_data_read_page Vincent Donnefort
2026-08-13 13:56 ` sashiko-bot
2026-08-14 1:04 ` Steven Rostedt
2026-08-13 13:11 ` [PATCH v5 04/10] ring-buffer: Fix subbuf resize race with ring buffer readers Vincent Donnefort
2026-08-13 13:51 ` sashiko-bot
2026-08-14 1:12 ` Steven Rostedt
2026-08-14 15:32 ` Masami Hiramatsu
2026-08-14 17:28 ` Steven Rostedt
2026-08-13 13:11 ` [PATCH v5 05/10] ring-buffer: Fix subbuf resize race with ring_buffer_alloc_read_page() Vincent Donnefort
2026-08-13 13:11 ` [PATCH v5 06/10] tracing: Fix subbuf resize races with trace_pipe_raw readers Vincent Donnefort
2026-08-13 13:53 ` sashiko-bot
2026-08-14 1:31 ` Steven Rostedt
2026-08-14 8:02 ` Vincent Donnefort
2026-09-01 12:34 ` STABLE REQ: " Lee Jones
2026-09-01 13:46 ` Steven Rostedt
2026-09-02 8:27 ` Lee Jones
2026-09-02 8:44 ` Greg KH
2026-09-02 9:57 ` Lee Jones
2026-09-02 11:38 ` Greg KH
2026-09-02 11:59 ` Lee Jones
2026-09-02 12:21 ` Steven Rostedt
2026-09-02 12:25 ` Steven Rostedt
2026-09-02 16:22 ` Lee Jones
2026-09-02 16:33 ` Steven Rostedt
2026-09-03 8:38 ` Lee Jones
2026-09-01 13:50 ` Vincent Donnefort
2026-09-02 22:14 ` Sasha Levin
2026-09-03 9:35 ` Vincent Donnefort
2026-09-03 12:34 ` Lee Jones
2026-09-03 12:44 ` Sasha Levin [this message]
2026-09-03 16:13 ` STABLE REQ: [PATCH v5 06/10] tracing: Fix subbuf resize races with trace_pipe_raw readers\ Lee Jones
2026-08-13 13:11 ` [PATCH v5 07/10] ring-buffer: Dynamically calculate max_data_size Vincent Donnefort
2026-08-14 1:34 ` Steven Rostedt
2026-08-14 7:59 ` Vincent Donnefort
2026-08-14 12:46 ` Steven Rostedt
2026-08-14 12:50 ` Vincent Donnefort
2026-08-13 13:11 ` [PATCH v5 08/10] ring-buffer: Remove trace_buffer::cpus Vincent Donnefort
2026-08-13 13:11 ` [PATCH v5 09/10] ring-buffer: Remove ring_buffer_per_cpu::mapped Vincent Donnefort
2026-08-13 13:11 ` [PATCH v5 10/10] ring-buffer: Make nr_pages unsigned int Vincent Donnefort
2026-08-13 13:55 ` sashiko-bot
2026-08-14 1:41 ` Steven Rostedt
2026-08-14 8:07 ` Vincent Donnefort
2026-08-14 12:37 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aplrlQbTRxAxMsAF@laps \
--to=sashal@kernel.org \
--cc=kernel-team@android.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox