From: Logan Gunthorpe <logang@deltatee.com>
To: Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Cc: Stephen Bates <sbates@raithlin.com>,
Jeff Dike <jdike@addtoit.com>, Al Viro <viro@ZenIV.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] um: add dummy ioremap and iounmap functions
Date: Thu, 25 May 2017 09:53:17 -0600 [thread overview]
Message-ID: <1bffdbbd-a317-d9a3-88d2-d02501d2fae1@deltatee.com> (raw)
In-Reply-To: <3c36765c-9e23-7947-b6d9-29ca892bd348@nod.at>
On 25/05/17 09:48 AM, Richard Weinberger wrote:
> Which ones are failing?
> I thought we killed the problem by making CONFIG_COMPILE_TEST depend on !UML.
None, at the moment. My work is trying to add iomem support to scatter
lists and thus I want to call ioremap in scatterlist.c. That's when
things fail to build. We could put an '#ifdef HAS_IOMEM' around only the
uses, but I thought this approach was cleaner. However, if people would
rather I do that, let me know and I will.
> I was never a fan of that approach because in my opinion drivers should have
> proper dependencies, including a dependency on HAS_IOMEM.
This doesn't really work when we try to use it in a core library which
can't depend on HAS_IOMEM.
Thanks,
Logan
next prev parent reply other threads:[~2017-05-25 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 15:42 [PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe
2017-05-25 15:48 ` Richard Weinberger
2017-05-25 15:53 ` Logan Gunthorpe [this message]
2017-05-27 18:08 ` Geert Uytterhoeven
2017-05-27 18:15 ` Logan Gunthorpe
2017-06-08 18:53 ` Logan Gunthorpe
2017-06-08 19:17 ` Richard Weinberger
2017-06-21 21:25 ` Logan Gunthorpe
2017-06-21 21:30 ` Richard Weinberger
2017-06-21 21:31 ` Logan Gunthorpe
2017-06-21 21:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bffdbbd-a317-d9a3-88d2-d02501d2fae1@deltatee.com \
--to=logang@deltatee.com \
--cc=arnd@arndb.de \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=sbates@raithlin.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox