linux-um archives
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Logan Gunthorpe <logang@deltatee.com>,
	linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net
Cc: Stephen Bates <sbates@raithlin.com>,
	Jeff Dike <jdike@addtoit.com>, Al Viro <viro@ZenIV.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] um: add dummy ioremap and iounmap functions
Date: Thu, 25 May 2017 17:48:28 +0200	[thread overview]
Message-ID: <3c36765c-9e23-7947-b6d9-29ca892bd348@nod.at> (raw)
In-Reply-To: <1495726955-27497-1-git-send-email-logang@deltatee.com>

Logan,

Am 25.05.2017 um 17:42 schrieb Logan Gunthorpe:
> The user mode architecture does not provide ioremap or iounmap, and
> because of this, the arch won't build when the functions are used in some
> core libraries.

Which ones are failing?
I thought we killed the problem by making CONFIG_COMPILE_TEST depend on !UML.

> I have designs to use these functions in scatterlist.c where they'd
> almost certainly never be called on the um architecture but it does need
> to compile. Thus, if the function is ever hit it returns NULL.

I was never a fan of that approach because in my opinion drivers should have
proper dependencies, including a dependency on HAS_IOMEM.

But I'll no longer block these attempts if we can get rid of tons of fallout
every kernel release.

Thanks,
//richard


  reply	other threads:[~2017-05-25 15:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 15:42 [PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe
2017-05-25 15:48 ` Richard Weinberger [this message]
2017-05-25 15:53   ` Logan Gunthorpe
2017-05-27 18:08     ` Geert Uytterhoeven
2017-05-27 18:15       ` Logan Gunthorpe
2017-06-08 18:53         ` Logan Gunthorpe
2017-06-08 19:17           ` Richard Weinberger
2017-06-21 21:25             ` Logan Gunthorpe
2017-06-21 21:30               ` Richard Weinberger
2017-06-21 21:31                 ` Logan Gunthorpe
2017-06-21 21:36                   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c36765c-9e23-7947-b6d9-29ca892bd348@nod.at \
    --to=richard@nod.at \
    --cc=arnd@arndb.de \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=sbates@raithlin.com \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox