[uml-devel] PATCH kernel/umid.c

[uml-devel] PATCH kernel/umid.c

[Dan Shearer]

--- umid.c.orig 2004-01-26 23:10:38.000000000 +1030
+++ umid.c      2004-01-26 23:11:41.000000000 +1030
@@ -205,7 +205,7 @@
                        printf("Failed to malloc uml_dir - error = %d\n",
                               errno);
                        uml_dir = name;
-                       return(0);
+                       return(1);
                }
                sprintf(uml_dir, "%s/", name);
        }

(and the sf list seems to have nearly completely stopped over the last
36 hours.)

-- 
Dan Shearer
dan@shearer.org


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

[uml-devel] Re: PATCH kernel/umid.c

[Dan Shearer]

In addition, umid.c seems to be a bit inconsistent as to what rates an
exit(1) and what just does return(1).

On Mon, Jan 26, 2004 at 11:17:08PM +1030, Dan Shearer wrote:
> --- umid.c.orig 2004-01-26 23:10:38.000000000 +1030
> +++ umid.c      2004-01-26 23:11:41.000000000 +1030
> @@ -205,7 +205,7 @@
>                         printf("Failed to malloc uml_dir - error = %d\n",
>                                errno);
>                         uml_dir = name;
> -                       return(0);
> +                       return(1);
>                 }
>                 sprintf(uml_dir, "%s/", name);
>         }

-- 
Dan Shearer
dan@shearer.org


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

[uml-devel] Re: PATCH kernel/umid.c

[Jeff Dike]

dan@shearer.org said:
> -                       return(0); 
> +                       return(1);

I did the return(0) on purpose because, even though initcall procedures are
declared as returning an int, do_initcalls ignores it.

So, I added a comment there instead of changing the return value.

> In addition, umid.c seems to be a bit inconsistent as to what rates an
> exit(1) and what just does return(1). 

Stuff that's done early, before the kernel is actually running, rates an 
exit(1).  Everything else gets a return(1).  I don't always follow this rule,
but I did a quick check of umid.c and it looks OK.

				Jeff


				Jeff



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel