Re: [uml-devel] post-2.6.3 build error

[BlaisorBlade <blaisorblade_spam@yahoo.it>]

Alle 18:20, lunedì 23 febbraio 2004, Gerd Knorr ha scritto:
>   Hi,
>
> You might have noticed already that in latest linus tree um doesn't
> build any more.  The reason is that sys_sched_setscheduler() is declared
> now in linux/sched.h, which conflicts with the declaration in
> arch/um/kernel/sys_call_table.c.  As quick+dirty fix I've just commented
> the declaration.  It builds now, but gives a warning (which is harmless I
> think as the exact type of the function shouldn't matter for the syscall
> table).  Anyone has a better/cleaner fix for that?

I agree that it's harmless (you can add a typecast as it is done for other 
functions there). By the way (unrelated) you could maybe remove include 
"linux/sys.h" since it claims to be unused.

Nothing cleaner since avoiding the inclusion of sched.h is impossible. And 
this is the fix used for similar cases in that file.

Also, please fix this line:

__NR_sched_yield ] = (syscall_handler_t *) yield

It should refer to sys_sched_yield. yield() is not even asmlinkage, so this 
could case serious problems, and it is commented as "for kernel usage". Also 
I checked i386 syscall table, and it uses sys_sched_yield.

Bye
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729



-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&opÌk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel