Re: [uml-devel] Re: post-2.6.3 build error

[BlaisorBlade <blaisorblade_spam@yahoo.it>]

Alle 22:12, mercoledì 25 febbraio 2004, Gerd Knorr ha scritto:
> BlaisorBlade <blaisorblade_spam@yahoo.it> writes:
> > __NR_sched_yield ] = (syscall_handler_t *) yield
> >
> > It should refer to sys_sched_yield. yield() is not even asmlinkage, so
> > this could case serious problems, and it is commented as "for kernel
> > usage". Also I checked i386 syscall table, and it uses sys_sched_yield.
>
> There is another related one (asmlinkage where it shouldn't be) in
> mprotect.c.

Good catch.

> With the new CONFIG_REGPARM config option it becomes
> really important to get that right ...

Yes, however I think that one asmlinkage more is not very bad (old convention 
used where the call can be optimized), but that a missing asmlinkage could be 
crashy. At least until the prototype is correct; I just noticed that 
do_mprotect is protoized without asmlinkage - and this can be actually 
crashy. Luckily CONFIG_REGPARM is not in the stock kernel.

If it were, that could have explained some Skas-2.6 crashes which can be seen 
here (there is already one BUG hit which explains it in part, see here: "Host 
2.6.2/3 + CFQ + BlaisorBlade patches"... but on one kernel it Oopsed and on 
another it crashed, so there could be something else).

-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729



-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&opÌk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel