linux-um archives
 help / color / mirror / Atom feed
From: Gerd Knorr <kraxel@bytesex.org>
To: user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: post-2.6.3 build error
Date: 25 Feb 2004 22:12:34 +0100	[thread overview]
Message-ID: <87smgyamnx.fsf@bytesex.org> (raw)
In-Reply-To: <200402252047.59002.blaisorblade_spam@yahoo.it>

BlaisorBlade <blaisorblade_spam@yahoo.it> writes:

> __NR_sched_yield ] = (syscall_handler_t *) yield
> 
> It should refer to sys_sched_yield. yield() is not even asmlinkage, so this 
> could case serious problems, and it is commented as "for kernel usage". Also 
> I checked i386 syscall table, and it uses sys_sched_yield.

There is another related one (asmlinkage where it shouldn't be) in
mprotect.c.  With the new CONFIG_REGPARM config option it becomes
really important to get that right ...

  Gerd

Index: linux-2.6.3/mm/mprotect.c
===================================================================
--- linux-2.6.3.orig/mm/mprotect.c
+++ linux-2.6.3/mm/mprotect.c
@@ -221,7 +221,7 @@ fail:
 	return error;
 }
 
-asmlinkage long
+long
 do_mprotect(struct mm_struct *mm, unsigned long start, size_t len, 
 	     unsigned long prot)
 {


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2004-02-25 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-23 17:20 [uml-devel] post-2.6.3 build error Gerd Knorr
2004-02-25 19:47 ` BlaisorBlade
2004-02-25 21:12   ` Gerd Knorr [this message]
2004-02-26 19:30     ` [uml-devel] " BlaisorBlade
2004-02-26 21:10       ` Gerd Knorr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87smgyamnx.fsf@bytesex.org \
    --to=kraxel@bytesex.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox