Re: [uml-devel] 2.4.26 and strstr

[BlaisorBlade <blaisorblade_spam@yahoo.it>]

On Monday 20 September 2004 02:29, Michael Richardson wrote:
> I recently moved from 2.4.19 for the Openswan regression tests to
> 2.4.26. (a number of kernels in between were just not as stable)

> I encountered a problem with strstr(). It was no longer available
> to modules. It did link okay when I built our code statically.. I don't
> know that is because it was linking (incorrectly) against libc, or what.
No, that is not incorrect, for UML - at least it has always done things that 
way. So it should suffice adding EXPORT_SYMBOL (and not EXPORT_SYMTAB) in the 
right place (see below).

However, in this particular case, you should just edit 
arch/um/kernel/user_ksyms.c and uncomment those EXPORT_SYMBOL at the top of 
the file. Don't care about the comment "they caused problem", it's not true 
in my experience.

> strstr() is an hand assembled in arch/i386/lib/strstr.c.
> As far as I can see, there is nothing to build any of the code there.

> I think that the answer is that arch/um/sys-i386 should have strstr.c
> added to the Makefile, but I'm far from sure on this. In particular,
> this does not seem to make the symbol available to modules.
> (yes, I threw EXPORT_SYMTAB in).

You mean EXPORT_SYMBOL, right? Remember to put it inside a file listed in 
export-objs in its Makefile (which means that you should put it inside 
arch/um/kernel/ksyms.c, or arch/um/sys-i386/ksyms.c).

> {I don't honestly know why this routine isn't inlined with the rest of
>  the string.h routines.}


> marajade-[openswan-2/nightly/UMLPOOL/plain] mcr 1019 %diff -u
> arch/um/sys-i386/Makefile~ arch/um/sys-i386/Makefile ---
> arch/um/sys-i386/Makefile~  2004-09-15 15:44:43.000000000 -0400 +++
> arch/um/sys-i386/Makefile   2004-09-19 20:23:27.000000000 -0400 @@ -6,15
> +6,16 @@
>  O_TARGET = built-in.o
>
>  obj-y = bugs.o checksum.o extable.o fault.o ksyms.o ldt.o ptrace.o \
> -       ptrace_user.o semaphore.o sigcontext.o syscalls.o sysrq.o
> +       ptrace_user.o semaphore.o sigcontext.o syscalls.o sysrq.o strstr.o
>  export-objs = ksyms.o
>
>  USER_OBJS = bugs.o ptrace_user.o sigcontext.o fault.o

> -SYMLINKS = semaphore.c extable.c
> +SYMLINKS = semaphore.c extable.c strstr.c

>  semaphore.c-dir = kernel
>  extable.c-dir = mm
> +strstr.c-dir = lib

Bye
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel