[uml-devel] 2.4.26 and strstr

[Michael Richardson <mcr@sandelman.ottawa.on.ca>]

-----BEGIN PGP SIGNED MESSAGE-----


I recently moved from 2.4.19 for the Openswan regression tests to
2.4.26. (a number of kernels in between were just not as stable)

I encountered a problem with strstr(). It was no longer available
to modules. It did link okay when I built our code statically.. I don't
know that is because it was linking (incorrectly) against libc, or what.

strstr() is an hand assembled in arch/i386/lib/strstr.c.
As far as I can see, there is nothing to build any of the code there.

I think that the answer is that arch/um/sys-i386 should have strstr.c
added to the Makefile, but I'm far from sure on this. In particular,
this does not seem to make the symbol available to modules.
(yes, I threw EXPORT_SYMTAB in).

{I don't honestly know why this routine isn't inlined with the rest of
 the string.h routines.}
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Finger me for keys

iQCVAwUBQU4kbYqHRg3pndX9AQGsfwP/Xl1BBOFH+2RzMatxY+t4FAecbyoqYZWu
mZhe6qft7+45eDkQUx+Pk4sfO2PSzryJJ8wxHjHPNkQeAby5y2Slzh8bJDseXu3D
vv7SadBQdKY2GByEaQOvU+Zz08nWM2K5XxxB4KxKdKnfv3Jr/A+aKDPnRn9A0qad
lu9fpEoRGik=
=zZGx
-----END PGP SIGNATURE-----


marajade-[openswan-2/nightly/UMLPOOL/plain] mcr 1019 %diff -u arch/um/sys-i386/Makefile~ arch/um/sys-i386/Makefile
--- arch/um/sys-i386/Makefile~  2004-09-15 15:44:43.000000000 -0400
+++ arch/um/sys-i386/Makefile   2004-09-19 20:23:27.000000000 -0400
@@ -6,15 +6,16 @@
 O_TARGET = built-in.o
 
 obj-y = bugs.o checksum.o extable.o fault.o ksyms.o ldt.o ptrace.o \
-       ptrace_user.o semaphore.o sigcontext.o syscalls.o sysrq.o
+       ptrace_user.o semaphore.o sigcontext.o syscalls.o sysrq.o strstr.o
 export-objs = ksyms.o
 
 USER_OBJS = bugs.o ptrace_user.o sigcontext.o fault.o
 
-SYMLINKS = semaphore.c extable.c
+SYMLINKS = semaphore.c extable.c strstr.c
 
 semaphore.c-dir = kernel
 extable.c-dir = mm
+strstr.c-dir = lib
 
 include $(TOPDIR)/Rules.make
 



-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel