Re: [uml-devel] 2.4.26 and strstr

[Michael Richardson <mcr@sandelman.ottawa.on.ca>]

-----BEGIN PGP SIGNED MESSAGE-----


>>>>> "BlaisorBlade" == BlaisorBlade  <blaisorblade_spam@yahoo.it> writes:
    >> I recently moved from 2.4.19 for the Openswan regression tests to
    >> 2.4.26. (a number of kernels in between were just not as stable)

    >> I encountered a problem with strstr(). It was no longer available
    >> to modules. It did link okay when I built our code statically.. I
    >> don't know that is because it was linking (incorrectly) against
    >> libc, or what.
    BlaisorBlade> No, that is not incorrect, for UML - at least it has
    BlaisorBlade> always done things that way. So it should suffice
    BlaisorBlade> adding EXPORT_SYMBOL (and not EXPORT_SYMTAB) in the
    BlaisorBlade> right place (see below).

  Oops, probably my brain-fart doing the wrong thing.

    BlaisorBlade> However, in this particular case, you should just edit
    BlaisorBlade> arch/um/kernel/user_ksyms.c and uncomment those
    BlaisorBlade> EXPORT_SYMBOL at the top of the file. Don't care about
    BlaisorBlade> the comment "they caused problem", it's not true in my
    BlaisorBlade> experience.

  Okay!
  Will this be in the next patch?
  Since I package up the testing environment that I use for Openswan,
and we have developers that want a quickstart script, it is important
that they don't have to do any extra patching.

    >> strstr() is an hand assembled in arch/i386/lib/strstr.c.  As far
    >> as I can see, there is nothing to build any of the code there.

    >> I think that the answer is that arch/um/sys-i386 should have
    >> strstr.c added to the Makefile, but I'm far from sure on this. In
    >> particular, this does not seem to make the symbol available to
    >> modules.  (yes, I threw EXPORT_SYMTAB in).

    BlaisorBlade> You mean EXPORT_SYMBOL, right? Remember to put it
    BlaisorBlade> inside a file listed in export-objs in its Makefile
    BlaisorBlade> (which means that you should put it inside
    BlaisorBlade> arch/um/kernel/ksyms.c, or arch/um/sys-i386/ksyms.c).

- --
]     "Elmo went to the wrong fundraiser" - The Simpson         |  firewalls  [
]   Michael Richardson,    Xelerance Corporation, Ottawa, ON    |net architect[
] mcr@xelerance.com      http://www.sandelman.ottawa.on.ca/mcr/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Finger me for keys

iQCVAwUBQVBfzoqHRg3pndX9AQGJBwP+LTEy3RVEjjZ2D+PKA8u28omukuK3o4ga
4YXkng5ZchDZQ5HzaClPd4HbgJ0a7s2Pywujv6MP9wZa6W8wvLLU2eL17V6sxsN7
Brxpt2FjTswlgTd3mIICsrP3KxLr6ZpTH34omZJaiDaQ1RQ9KV7UdwPI9EUj1SGG
eoNk5M8VwHI=
=4wtw
-----END PGP SIGNATURE-----


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel