* [uml-devel] Bug in for-each-cpu-akpm from incrementals
@ 2005-01-11 1:01 Blaisorblade
2005-01-11 4:43 ` Jeff Dike
2005-01-11 20:35 ` [uml-devel] " Jeff Dike
0 siblings, 2 replies; 3+ messages in thread
From: Blaisorblade @ 2005-01-11 1:01 UTC (permalink / raw)
To: Jeff Dike; +Cc: user-mode-linux-devel
You think that for_each_cpu() only iterates over online CPU, while you should
use for_each_online_cpu() for this purpose.
http://user-mode-linux.sourceforge.net/work/current/2.6/2.6.10-mm2/patches/for-each-cpu-akpm
Bye
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [uml-devel] Bug in for-each-cpu-akpm from incrementals
2005-01-11 1:01 [uml-devel] Bug in for-each-cpu-akpm from incrementals Blaisorblade
@ 2005-01-11 4:43 ` Jeff Dike
2005-01-11 20:35 ` [uml-devel] " Jeff Dike
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Dike @ 2005-01-11 4:43 UTC (permalink / raw)
To: Blaisorblade; +Cc: user-mode-linux-devel
blaisorblade@yahoo.it said:
> You think that for_each_cpu() only iterates over online CPU, while you
> should use for_each_online_cpu() for this purpose.
Oops, correct.
Jeff
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [uml-devel] Re: Bug in for-each-cpu-akpm from incrementals
2005-01-11 1:01 [uml-devel] Bug in for-each-cpu-akpm from incrementals Blaisorblade
2005-01-11 4:43 ` Jeff Dike
@ 2005-01-11 20:35 ` Jeff Dike
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Dike @ 2005-01-11 20:35 UTC (permalink / raw)
To: Blaisorblade; +Cc: user-mode-linux-devel
blaisorblade@yahoo.it said:
> You think that for_each_cpu() only iterates over online CPU, while you
> should use for_each_online_cpu() for this purpose.
Fixed in my tree, but there was method to my madness. I spotted this while
reading the 2.6.10 patch, which has this:
@@ -207,9 +212,8 @@ int show_interrupts(struct seq_file *p,
if (i == 0) {
seq_printf(p, " ");
- for (j=0; j<NR_CPUS; j++)
- if (cpu_online(j))
- seq_printf(p, "CPU%d ",j);
+ for_each_cpu(j)
+ seq_printf(p, "CPU%d ",j);
seq_putc(p, '\n');
}
which would appear to be wrong as well.
Jeff
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-11 18:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-11 1:01 [uml-devel] Bug in for-each-cpu-akpm from incrementals Blaisorblade
2005-01-11 4:43 ` Jeff Dike
2005-01-11 20:35 ` [uml-devel] " Jeff Dike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox