[uml-devel] potentially dead CONFIG variables under arch/um

[uml-devel] potentially dead CONFIG variables under arch/um

[Robert P. J. Day]

========== HARDDOG_NOWAYOUT ==========
arch/um/drivers/harddog_kern.c:72:#ifdef CONFIG_HARDDOG_NOWAYOUT
========== PROC_MM ==========
arch/um/kernel/ptrace.c:13:#ifdef CONFIG_PROC_MM
arch/um/kernel/ptrace.c:227:#ifdef CONFIG_PROC_MM
========== TTY_LOG ==========
arch/um/os-Linux/Makefile:15:obj-$(CONFIG_TTY_LOG) += tty_log.o
arch/um/os-Linux/Makefile:16:user-objs-$(CONFIG_TTY_LOG) += tty_log.o
arch/um/kernel/exec.c:34:#ifdef CONFIG_TTY_LOG
arch/um/kernel/exec.c:42:#ifdef CONFIG_TTY_LOG

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] potentially dead CONFIG variables under arch/um

[Jeff Dike]

Oops, sorry for ignoring your last post...

On Tue, Jul 17, 2007 at 07:24:09AM -0400, Robert P. J. Day wrote:
> 
> ========== HARDDOG_NOWAYOUT ==========
> arch/um/drivers/harddog_kern.c:72:#ifdef CONFIG_HARDDOG_NOWAYOUT

This looks bogus.  There is a WATCHDOG_NOWAYOUT and I think we should
use that instead.

> ========== PROC_MM ==========
> arch/um/kernel/ptrace.c:13:#ifdef CONFIG_PROC_MM
> arch/um/kernel/ptrace.c:227:#ifdef CONFIG_PROC_MM
> ========== TTY_LOG ==========
> arch/um/os-Linux/Makefile:15:obj-$(CONFIG_TTY_LOG) += tty_log.o
> arch/um/os-Linux/Makefile:16:user-objs-$(CONFIG_TTY_LOG) += tty_log.o
> arch/um/kernel/exec.c:34:#ifdef CONFIG_TTY_LOG
> arch/um/kernel/exec.c:42:#ifdef CONFIG_TTY_LOG

These two are used, but in code which is not yet merged.  These
references leaked into mainline by accident.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] potentially dead CONFIG variables under arch/um

[Robert P. J. Day]

On Tue, 17 Jul 2007, Jeff Dike wrote:

> Oops, sorry for ignoring your last post...
>
> On Tue, Jul 17, 2007 at 07:24:09AM -0400, Robert P. J. Day wrote:
> >
> > ========== HARDDOG_NOWAYOUT ==========
> > arch/um/drivers/harddog_kern.c:72:#ifdef CONFIG_HARDDOG_NOWAYOUT
>
> This looks bogus.  There is a WATCHDOG_NOWAYOUT and I think we
> should use that instead.

be careful, as there are two different Kconfig files that define that
Kconfig variable:

$ grep -w WATCHDOG_NOWAYOUT $(find . -name Kconfig*)
./drivers/char/watchdog/Kconfig:config WATCHDOG_NOWAYOUT
./arch/um/Kconfig.char:config WATCHDOG_NOWAYOUT

just making sure you noticed that.

> > ========== PROC_MM ==========
> > arch/um/kernel/ptrace.c:13:#ifdef CONFIG_PROC_MM
> > arch/um/kernel/ptrace.c:227:#ifdef CONFIG_PROC_MM
> > ========== TTY_LOG ==========
> > arch/um/os-Linux/Makefile:15:obj-$(CONFIG_TTY_LOG) += tty_log.o
> > arch/um/os-Linux/Makefile:16:user-objs-$(CONFIG_TTY_LOG) += tty_log.o
> > arch/um/kernel/exec.c:34:#ifdef CONFIG_TTY_LOG
> > arch/um/kernel/exec.c:42:#ifdef CONFIG_TTY_LOG
>
> These two are used, but in code which is not yet merged.  These
> references leaked into mainline by accident.
>
> 				Jeff

so i'll leave the above in your capable hands, then.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel