From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: richard@nod.at, linux-um@lists.infradead.org, hch@lst.de,
anton.ivanov@cambridgegreys.com
Subject: Re: [PATCH 2/4] um: Clean-up command processing in UML UBD driver
Date: Wed, 14 Nov 2018 16:28:42 +0100 [thread overview]
Message-ID: <20181114152842.GA28557@lst.de> (raw)
In-Reply-To: <8a1d3dcb-ea52-e745-b961-ea51224d2405@kernel.dk>
On Tue, Nov 13, 2018 at 06:34:31AM -0700, Jens Axboe wrote:
> > + /* operations with bio_vec arguments */
> > + case REQ_OP_READ:
> > + case REQ_OP_WRITE:
> > + {
> > + struct req_iterator iter;
> > + struct bio_vec bvec;
> > + u64 off = (u64)blk_rq_pos(req) << 9;
> > +
> > + rq_for_each_segment(bvec, req, iter) {
> > + ret = ubd_queue_one_vec(hctx, req, off, &bvec);
> > + if (ret < 0)
> > + goto out;
> > + off += bvec.bv_len;
> > + }
> > }
> > + break;
>
> This indentation is wrong/awkward. The usual style is:
And for extra point just split the code into a separate helper,
avoiding the whole switch scoping issue entirely.
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2018-11-14 15:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 11:59 Revised and fixed patchset anton.ivanov
2018-11-13 11:59 ` [PATCH 1/4] um: Switch to block-mq constants in the UML UBD driver anton.ivanov
2018-11-13 13:33 ` Jens Axboe
2018-11-14 15:32 ` Christoph Hellwig
2018-11-14 17:00 ` Jens Axboe
2018-11-14 17:04 ` Anton Ivanov
2018-11-13 11:59 ` [PATCH 2/4] um: Clean-up command processing in " anton.ivanov
2018-11-13 13:34 ` Jens Axboe
2018-11-14 15:28 ` Christoph Hellwig [this message]
2018-11-14 15:31 ` Anton Ivanov
2018-11-14 15:33 ` Christoph Hellwig
2018-11-13 11:59 ` [PATCH 3/4] um: Remove unsafe printks from the io thread anton.ivanov
2018-11-13 13:31 ` Jens Axboe
2018-11-13 11:59 ` [PATCH 4/4] um: Add support for DISCARD in the UBD Driver anton.ivanov
2018-11-13 13:40 ` Jens Axboe
2018-11-13 14:04 ` Anton Ivanov
2018-11-13 15:18 ` Jens Axboe
2018-11-13 15:32 ` Anton Ivanov
2018-11-13 15:49 ` Jens Axboe
2018-11-13 15:52 ` Anton Ivanov
2018-11-14 15:30 ` Christoph Hellwig
2018-11-14 15:35 ` Anton Ivanov
-- strict thread matches above, loose matches on Subject: below --
2018-11-14 8:10 [PATCH 1/4] um: Switch to block-mq constants in the UML UBD driver anton.ivanov
2018-11-14 8:10 ` [PATCH 2/4] um: Clean-up command processing in " anton.ivanov
2018-11-14 17:09 [PATCH 1/4] um: Switch to block-mq constants in the " anton.ivanov
2018-11-14 17:09 ` [PATCH 2/4] um: Clean-up command processing in " anton.ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114152842.GA28557@lst.de \
--to=hch@lst.de \
--cc=anton.ivanov@cambridgegreys.com \
--cc=axboe@kernel.dk \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox