From: Jens Axboe <axboe@kernel.dk>
To: anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org
Cc: richard@nod.at, hch@lst.de
Subject: Re: [PATCH 3/4] um: Remove unsafe printks from the io thread
Date: Tue, 13 Nov 2018 06:31:44 -0700 [thread overview]
Message-ID: <985e1e06-e779-047f-3ce3-fbd3c67a15de@kernel.dk> (raw)
In-Reply-To: <20181113115947.19290-4-anton.ivanov@cambridgegreys.com>
On 11/13/18 4:59 AM, anton.ivanov@cambridgegreys.com wrote:
> From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>
> Printk out of the io thread has been proven to be unsafe. It is
> safer to pass the error to the block IO layer nad let it print
> it if need be.
As per previous message, I don't think this is a good idea at all.
It'd be much better to fix the real issue, not work around it.
--
Jens Axboe
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2018-11-13 13:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 11:59 Revised and fixed patchset anton.ivanov
2018-11-13 11:59 ` [PATCH 1/4] um: Switch to block-mq constants in the UML UBD driver anton.ivanov
2018-11-13 13:33 ` Jens Axboe
2018-11-14 15:32 ` Christoph Hellwig
2018-11-14 17:00 ` Jens Axboe
2018-11-14 17:04 ` Anton Ivanov
2018-11-13 11:59 ` [PATCH 2/4] um: Clean-up command processing in " anton.ivanov
2018-11-13 13:34 ` Jens Axboe
2018-11-14 15:28 ` Christoph Hellwig
2018-11-14 15:31 ` Anton Ivanov
2018-11-14 15:33 ` Christoph Hellwig
2018-11-13 11:59 ` [PATCH 3/4] um: Remove unsafe printks from the io thread anton.ivanov
2018-11-13 13:31 ` Jens Axboe [this message]
2018-11-13 11:59 ` [PATCH 4/4] um: Add support for DISCARD in the UBD Driver anton.ivanov
2018-11-13 13:40 ` Jens Axboe
2018-11-13 14:04 ` Anton Ivanov
2018-11-13 15:18 ` Jens Axboe
2018-11-13 15:32 ` Anton Ivanov
2018-11-13 15:49 ` Jens Axboe
2018-11-13 15:52 ` Anton Ivanov
2018-11-14 15:30 ` Christoph Hellwig
2018-11-14 15:35 ` Anton Ivanov
-- strict thread matches above, loose matches on Subject: below --
2018-11-14 8:10 [PATCH 1/4] um: Switch to block-mq constants in the UML UBD driver anton.ivanov
2018-11-14 8:10 ` [PATCH 3/4] um: Remove unsafe printks from the io thread anton.ivanov
2018-11-14 9:35 ` Geert Uytterhoeven
2018-11-14 9:53 ` Anton Ivanov
2018-11-14 17:09 [PATCH 1/4] um: Switch to block-mq constants in the UML UBD driver anton.ivanov
2018-11-14 17:09 ` [PATCH 3/4] um: Remove unsafe printks from the io thread anton.ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=985e1e06-e779-047f-3ce3-fbd3c67a15de@kernel.dk \
--to=axboe@kernel.dk \
--cc=anton.ivanov@cambridgegreys.com \
--cc=hch@lst.de \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox