From: Christoph Hellwig <hch@lst.de>
To: anton.ivanov@cambridgegreys.com
Cc: axboe@kernel.dk, richard@nod.at, linux-um@lists.infradead.org,
hch@lst.de
Subject: Re: [PATCH 1/4] um: Switch to block-mq constants in the UML UBD driver
Date: Wed, 14 Nov 2018 16:32:37 +0100 [thread overview]
Message-ID: <20181114153237.GA28669@lst.de> (raw)
In-Reply-To: <20181113115947.19290-2-anton.ivanov@cambridgegreys.com>
> +#define UBD_SECTOR_SIZE (1 << 9)
This can just use SECTOR_SIZE I guess.
> + if (!blk_update_request(io_req->req, io_req->error, io_req->length))
> + __blk_mq_end_request(io_req->req, io_req->error);
The driver reall should be using blk_mq_end_request instead of playing
games with blk_update_request and __blk_mq_end_request.
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2018-11-14 15:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 11:59 Revised and fixed patchset anton.ivanov
2018-11-13 11:59 ` [PATCH 1/4] um: Switch to block-mq constants in the UML UBD driver anton.ivanov
2018-11-13 13:33 ` Jens Axboe
2018-11-14 15:32 ` Christoph Hellwig [this message]
2018-11-14 17:00 ` Jens Axboe
2018-11-14 17:04 ` Anton Ivanov
2018-11-13 11:59 ` [PATCH 2/4] um: Clean-up command processing in " anton.ivanov
2018-11-13 13:34 ` Jens Axboe
2018-11-14 15:28 ` Christoph Hellwig
2018-11-14 15:31 ` Anton Ivanov
2018-11-14 15:33 ` Christoph Hellwig
2018-11-13 11:59 ` [PATCH 3/4] um: Remove unsafe printks from the io thread anton.ivanov
2018-11-13 13:31 ` Jens Axboe
2018-11-13 11:59 ` [PATCH 4/4] um: Add support for DISCARD in the UBD Driver anton.ivanov
2018-11-13 13:40 ` Jens Axboe
2018-11-13 14:04 ` Anton Ivanov
2018-11-13 15:18 ` Jens Axboe
2018-11-13 15:32 ` Anton Ivanov
2018-11-13 15:49 ` Jens Axboe
2018-11-13 15:52 ` Anton Ivanov
2018-11-14 15:30 ` Christoph Hellwig
2018-11-14 15:35 ` Anton Ivanov
-- strict thread matches above, loose matches on Subject: below --
2018-11-14 8:10 [PATCH 1/4] um: Switch to block-mq constants in the UML UBD driver anton.ivanov
2018-11-14 17:09 anton.ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114153237.GA28669@lst.de \
--to=hch@lst.de \
--cc=anton.ivanov@cambridgegreys.com \
--cc=axboe@kernel.dk \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox