* [PATCH] um: Rename print_stack_trace to do_stack_trace
@ 2013-11-21 8:31 Richard Weinberger
2013-11-21 17:02 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Richard Weinberger @ 2013-11-21 8:31 UTC (permalink / raw)
To: richard; +Cc: user-mode-linux-devel, linux-kernel, rdunlap
We cannot use print_stack_trace because the name conflicts
with linux/stacktrace.h.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
arch/um/kernel/sysrq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
index 4d6fdf6..799d7e4 100644
--- a/arch/um/kernel/sysrq.c
+++ b/arch/um/kernel/sysrq.c
@@ -19,7 +19,7 @@ struct stack_frame {
unsigned long return_address;
};
-static void print_stack_trace(unsigned long *sp, unsigned long bp)
+static void do_stack_trace(unsigned long *sp, unsigned long bp)
{
int reliable;
unsigned long addr;
@@ -94,5 +94,5 @@ void show_stack(struct task_struct *task, unsigned long *stack)
}
printk(KERN_CONT "\n");
- print_stack_trace(sp, bp);
+ do_stack_trace(sp, bp);
}
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] um: Rename print_stack_trace to do_stack_trace
2013-11-21 8:31 [PATCH] um: Rename print_stack_trace to do_stack_trace Richard Weinberger
@ 2013-11-21 17:02 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2013-11-21 17:02 UTC (permalink / raw)
To: Richard Weinberger; +Cc: user-mode-linux-devel, linux-kernel
On 11/21/13 00:31, Richard Weinberger wrote:
> We cannot use print_stack_trace because the name conflicts
> with linux/stacktrace.h.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> arch/um/kernel/sysrq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
> index 4d6fdf6..799d7e4 100644
> --- a/arch/um/kernel/sysrq.c
> +++ b/arch/um/kernel/sysrq.c
> @@ -19,7 +19,7 @@ struct stack_frame {
> unsigned long return_address;
> };
>
> -static void print_stack_trace(unsigned long *sp, unsigned long bp)
> +static void do_stack_trace(unsigned long *sp, unsigned long bp)
> {
> int reliable;
> unsigned long addr;
> @@ -94,5 +94,5 @@ void show_stack(struct task_struct *task, unsigned long *stack)
> }
> printk(KERN_CONT "\n");
>
> - print_stack_trace(sp, bp);
> + do_stack_trace(sp, bp);
> }
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-21 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-21 8:31 [PATCH] um: Rename print_stack_trace to do_stack_trace Richard Weinberger
2013-11-21 17:02 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox