[PATCH v2] overlay/081: add missing _require_scratch check

[PATCH v2] overlay/081: add missing _require_scratch check

[Prabhakar Pujeri]

The test runs _scratch_mkfs without first requiring a scratch device, so it fails messily instead of skipping when no scratch device is configured.  Add _require_scratch so the test skips cleanly when no scratch device is present.

Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
---
Changes in v2:
- Use _require_scratch instead of _require_scratch_nocheck and drop the
  comment copied from overlay/079/080, which does not apply to this test.
  Add Amir's Reviewed-by.
v1: https://lore.kernel.org/fstests/20260831104154.2256-1-prabhakar.pujeri@dell.com/

 tests/overlay/081 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/overlay/081 b/tests/overlay/081
index 2270a04..e0ab558 100755
--- a/tests/overlay/081
+++ b/tests/overlay/081
@@ -14,6 +14,7 @@ _begin_fstest auto quick
 . ./common/filter
 . ./common/attr
 
+_require_scratch
 
 _scratch_mkfs >>$seqres.full 2>&1
 
-- 
2.55.0

Re: [PATCH v2] overlay/081: add missing _require_scratch check

[Zorro Lang]

On Tue, Sep 01, 2026 at 01:24:38PM +0000, Prabhakar Pujeri wrote:
> The test runs _scratch_mkfs without first requiring a scratch device, so it fails messily instead of skipping when no scratch device is configured.  Add _require_scratch so the test skips cleanly when no scratch device is present.
> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> ---
> Changes in v2:
> - Use _require_scratch instead of _require_scratch_nocheck and drop the
>   comment copied from overlay/079/080, which does not apply to this test.
>   Add Amir's Reviewed-by.
> v1: https://lore.kernel.org/fstests/20260831104154.2256-1-prabhakar.pujeri@dell.com/
> 
>  tests/overlay/081 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/overlay/081 b/tests/overlay/081
> index 2270a04..e0ab558 100755
> --- a/tests/overlay/081
> +++ b/tests/overlay/081
> @@ -14,6 +14,7 @@ _begin_fstest auto quick
>  . ./common/filter
>  . ./common/attr
>  
> +_require_scratch

As you're fixing this patch, I'm wondering if we need a _require_* helper to
make sure the mount options *uuid=null/auto/on* is supported by current system?
Due to the comment says "mount options uuid=null/auto/on introduced in kernel
v6.6" :)

>  
>  _scratch_mkfs >>$seqres.full 2>&1
>  
> -- 
> 2.55.0
>