From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: crag0715@gmail.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hayeswang@realtek.com,
mario_limonciello@dell.com, "Crag.Wang" <crag.wang@dell.com>,
"David S. Miller" <davem@davemloft.net>,
Simon Glass <sjg@chromium.org>,
Grant Grundler <grundler@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
David Chen <david.chen7@dell.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Charles Hyde <charles.hyde@dell.corp-partner.google.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
zhong jiang <zhongjiang@huawei.com>
Subject: [v2,1/1] r8152: sync sa_family with the media type of network device
Date: Mon, 22 Apr 2019 13:39:47 -0700 [thread overview]
Message-ID: <20190422133947.0b6aaf82@cakuba.netronome.com> (raw)
On Mon, 22 Apr 2019 13:03:43 +0800, crag0715@gmail.com wrote:
> From: "Crag.Wang" <crag.wang@dell.com>
>
> Without this patch the socket address family sporadically gets wrong
> value ends up the dev_set_mac_address() fails to set the desired MAC
> address.
>
> Signed-off-by: Crag.Wang <crag.wang@dell.com>
Code looks reasonable. This must have been caused by:
Fixes: 25766271e42f ("r8152: Refresh MAC address during USBDEVFS_RESET")
which is still in net-next. In the future please make sure you read:
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
In particular:
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in
To assure smooth flow of your patches into the tree :)
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 4c63b40d5e00..41fb39ce69c9 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
> struct net_device *dev = tp->netdev;
> int ret;
>
> + sa->sa_family = dev->type;
> +
> if (tp->version == RTL_VER_01) {
> ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
> } else {
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: crag0715@gmail.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hayeswang@realtek.com,
mario_limonciello@dell.com, "Crag.Wang" <crag.wang@dell.com>,
"David S. Miller" <davem@davemloft.net>,
Simon Glass <sjg@chromium.org>,
Grant Grundler <grundler@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
David Chen <david.chen7@dell.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Charles Hyde <charles.hyde@dell.corp-partner.google.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
zhong jiang <zhongjiang@huawei.com>
Subject: Re: [PATCH v2 1/1] r8152: sync sa_family with the media type of network device
Date: Mon, 22 Apr 2019 13:39:47 -0700 [thread overview]
Message-ID: <20190422133947.0b6aaf82@cakuba.netronome.com> (raw)
Message-ID: <20190422203947.e8XQN1SwO3XYlEE53VOwHTLbn2NYQq1UXHfYlrFimic@z> (raw)
In-Reply-To: <20190422050344.24513-1-crag0715@gmail.com>
On Mon, 22 Apr 2019 13:03:43 +0800, crag0715@gmail.com wrote:
> From: "Crag.Wang" <crag.wang@dell.com>
>
> Without this patch the socket address family sporadically gets wrong
> value ends up the dev_set_mac_address() fails to set the desired MAC
> address.
>
> Signed-off-by: Crag.Wang <crag.wang@dell.com>
Code looks reasonable. This must have been caused by:
Fixes: 25766271e42f ("r8152: Refresh MAC address during USBDEVFS_RESET")
which is still in net-next. In the future please make sure you read:
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
In particular:
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in
To assure smooth flow of your patches into the tree :)
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 4c63b40d5e00..41fb39ce69c9 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
> struct net_device *dev = tp->netdev;
> int ret;
>
> + sa->sa_family = dev->type;
> +
> if (tp->version == RTL_VER_01) {
> ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
> } else {
next prev reply other threads:[~2019-04-22 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 5:03 [v2,1/1] r8152: sync sa_family with the media type of network device crag0715
2019-04-22 5:03 ` [PATCH v2 1/1] " crag0715
2019-04-22 20:39 ` Jakub Kicinski [this message]
2019-04-22 20:39 ` Jakub Kicinski
2019-04-23 2:52 ` [v2,1/1] " crag0715
2019-04-23 2:52 ` [PATCH v2 1/1] " Crag Wang
2019-04-22 21:29 ` [v2,1/1] " Mario Limonciello
2019-04-22 21:29 ` [PATCH v2 1/1] " Mario.Limonciello
2019-04-23 5:15 ` [v2,1/1] " David Miller
2019-04-23 5:15 ` [PATCH v2 1/1] " David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-04-22 4:48 [v2,1/1] " David Miller
2019-04-22 3:17 crag0715
2019-04-22 2:44 David Miller
2019-04-22 2:23 crag0715
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422133947.0b6aaf82@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=bigeasy@linutronix.de \
--cc=charles.hyde@dell.corp-partner.google.com \
--cc=crag.wang@dell.com \
--cc=crag0715@gmail.com \
--cc=davem@davemloft.net \
--cc=david.chen7@dell.com \
--cc=grundler@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=hayeswang@realtek.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=netdev@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=sjg@chromium.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox