Linux USB
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-usb@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <b-liu@ti.com>, <yangyingliang@huawei.com>
Subject: [PATCH -next resend 3/5] usb: musb: cppi41: Switch to use dev_err_probe() helper
Date: Mon, 26 Sep 2022 22:15:08 +0800	[thread overview]
Message-ID: <20220926141510.2265523-4-yangyingliang@huawei.com> (raw)
In-Reply-To: <20220926141510.2265523-1-yangyingliang@huawei.com>

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/usb/musb/musb_cppi41.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c
index c963cb8565f2..9589243e8951 100644
--- a/drivers/usb/musb/musb_cppi41.c
+++ b/drivers/usb/musb/musb_cppi41.c
@@ -718,10 +718,8 @@ static int cppi41_dma_controller_start(struct cppi41_dma_controller *controller)
 
 		dc = dma_request_chan(dev->parent, str);
 		if (IS_ERR(dc)) {
-			ret = PTR_ERR(dc);
-			if (ret != -EPROBE_DEFER)
-				dev_err(dev, "Failed to request %s: %d.\n",
-					str, ret);
+			ret = dev_err_probe(dev, PTR_ERR(dc),
+					    "Failed to request %s.\n", str);
 			goto err;
 		}
 
-- 
2.25.1


  parent reply	other threads:[~2022-09-26 15:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 14:15 [PATCH -next resend 0/5] usb: musb: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-26 14:15 ` [PATCH -next resend 1/5] usb: musb: core: " Yang Yingliang
2022-09-26 19:12   ` Sergei Shtylyov
2022-09-27  1:17     ` Yang Yingliang
2022-09-26 14:15 ` [PATCH -next resend 2/5] usb: musb: da8xx: " Yang Yingliang
2022-09-26 14:15 ` Yang Yingliang [this message]
2022-09-26 14:15 ` [PATCH -next resend 4/5] usb: musb: jz4740: " Yang Yingliang
2022-09-26 14:15 ` [PATCH -next resend 5/5] usb: musb: sunxi: " Yang Yingliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926141510.2265523-4-yangyingliang@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=b-liu@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox