Re: [PATCH -next resend 1/5] usb: musb: core: Switch to use dev_err_probe() helper

[Sergei Shtylyov <sergei.shtylyov@gmail.com>]

Hello!

On 9/26/22 5:15 PM, Yang Yingliang wrote:

> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/usb/musb/musb_core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index bbbcfd49fb35..37ef9d8cb8ea 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -2595,9 +2595,8 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
>  	musb_platform_exit(musb);
>  
>  fail1:
> -	if (status != -EPROBE_DEFER)
> -		dev_err(musb->controller,
> -			"%s failed with status %d\n", __func__, status);
> +	dev_err_probe(musb->controller, status,
> +		      "%s failed with status\n", __func__);

   Printing "with status" when you no longer print the status itself has no sense.

[...]

MBR, Sergey