Linux USB
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-usb@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <b-liu@ti.com>, <yangyingliang@huawei.com>
Subject: [PATCH -next resend 4/5] usb: musb: jz4740: Switch to use dev_err_probe() helper
Date: Mon, 26 Sep 2022 22:15:09 +0800	[thread overview]
Message-ID: <20220926141510.2265523-5-yangyingliang@huawei.com> (raw)
In-Reply-To: <20220926141510.2265523-1-yangyingliang@huawei.com>

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/usb/musb/jz4740.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
index 417c30bff9ca..d1e4e0deb753 100644
--- a/drivers/usb/musb/jz4740.c
+++ b/drivers/usb/musb/jz4740.c
@@ -105,7 +105,6 @@ static int jz4740_musb_init(struct musb *musb)
 		.driver_data = glue,
 		.fwnode = dev_fwnode(dev),
 	};
-	int err;
 
 	glue->musb = musb;
 
@@ -113,12 +112,9 @@ static int jz4740_musb_init(struct musb *musb)
 		musb->xceiv = devm_usb_get_phy_by_phandle(dev, "phys", 0);
 	else
 		musb->xceiv = devm_usb_get_phy(dev, USB_PHY_TYPE_USB2);
-	if (IS_ERR(musb->xceiv)) {
-		err = PTR_ERR(musb->xceiv);
-		if (err != -EPROBE_DEFER)
-			dev_err(dev, "No transceiver configured: %d\n", err);
-		return err;
-	}
+	if (IS_ERR(musb->xceiv))
+		return dev_err_probe(dev, PTR_ERR(musb->xceiv),
+				     "No transceiver configured\n");
 
 	glue->role_sw = usb_role_switch_register(dev, &role_sw_desc);
 	if (IS_ERR(glue->role_sw)) {
-- 
2.25.1


  parent reply	other threads:[~2022-09-26 15:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 14:15 [PATCH -next resend 0/5] usb: musb: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-26 14:15 ` [PATCH -next resend 1/5] usb: musb: core: " Yang Yingliang
2022-09-26 19:12   ` Sergei Shtylyov
2022-09-27  1:17     ` Yang Yingliang
2022-09-26 14:15 ` [PATCH -next resend 2/5] usb: musb: da8xx: " Yang Yingliang
2022-09-26 14:15 ` [PATCH -next resend 3/5] usb: musb: cppi41: " Yang Yingliang
2022-09-26 14:15 ` Yang Yingliang [this message]
2022-09-26 14:15 ` [PATCH -next resend 5/5] usb: musb: sunxi: " Yang Yingliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926141510.2265523-5-yangyingliang@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=b-liu@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox