public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Henrie <alexhenrie24@gmail.com>
To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org,
	sudipm.mukherjee@gmail.com, johan@kernel.org,
	daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com,
	reboots@g-cipher.net, mike@trausch.us
Cc: Alex Henrie <alexhenrie24@gmail.com>
Subject: [PATCH 6/7] usb: misc: uss720: add support for another variant of the Belkin F5U002
Date: Mon, 11 Mar 2024 23:50:31 -0600	[thread overview]
Message-ID: <20240312055350.205878-6-alexhenrie24@gmail.com> (raw)
In-Reply-To: <20240312055350.205878-1-alexhenrie24@gmail.com>

This device is a gray USB parallel port adapter with "F5U002" imprinted
on the plastic and a sticker that says both "F5U002" and "P80453-A".
It's identified in lsusb as "05ab:1001 In-System Design BAYI Printer
Class Support". It's subtly different from the other gray cable I have
that has "F5U002 Rev 2" and "P80453-B" on its sticker and device ID
050d:0002.

The uss720 driver appears to work flawlessly with this device, although
the device evidently does not support ECP.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 drivers/usb/misc/uss720.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index 15cafc7dfd22..5803919d7cc4 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -693,7 +693,7 @@ static int uss720_probe(struct usb_interface *intf,
 
 	interface = intf->cur_altsetting;
 
-	if (interface->desc.bNumEndpoints < 3) {
+	if (interface->desc.bNumEndpoints < 2) {
 		usb_put_dev(usbdev);
 		return -ENODEV;
 	}
@@ -719,7 +719,9 @@ static int uss720_probe(struct usb_interface *intf,
 
 	priv->pp = pp;
 	pp->private_data = priv;
-	pp->modes = PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_ECP | PARPORT_MODE_COMPAT;
+	pp->modes = PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_COMPAT;
+	if (interface->desc.bNumEndpoints >= 3)
+		pp->modes |= PARPORT_MODE_ECP;
 	pp->dev = &usbdev->dev;
 
 	/* set the USS720 control register to manual mode, no ECP compression, enable all ints */
@@ -774,6 +776,7 @@ static const struct usb_device_id uss720_table[] = {
 	{ USB_DEVICE(0x050d, 0x1202) }, /* Belkin F5U120-PC */
 	{ USB_DEVICE(0x0557, 0x2001) },
 	{ USB_DEVICE(0x05ab, 0x0002) }, /* Belkin F5U002 ISD-101 */
+	{ USB_DEVICE(0x05ab, 0x1001) }, /* Belkin F5U002 P80453-A */
 	{ USB_DEVICE(0x06c6, 0x0100) }, /* Infowave ISD-103 */
 	{ USB_DEVICE(0x0729, 0x1284) },
 	{ USB_DEVICE(0x1293, 0x0002) },
-- 
2.44.0


  parent reply	other threads:[~2024-03-12  5:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  5:50 [PATCH 1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP Alex Henrie
2024-03-12  5:50 ` [PATCH 2/7] usb: serial: mos7720: don't advertise PARPORT_MODE_PCSPP Alex Henrie
2024-03-12  7:39   ` Johan Hovold
2024-03-12  9:53     ` Sudip Mukherjee
2024-03-12 15:27       ` Daniel Gimpelevich
2024-03-13  1:30     ` Alex Henrie
2024-03-26  9:10   ` Greg KH
2024-03-12  5:50 ` [PATCH 3/7] usb: misc: uss720: " Alex Henrie
2024-03-12  5:50 ` [PATCH 4/7] usb: misc: uss720: point pp->dev to usbdev->dev Alex Henrie
2024-03-12  7:40   ` Johan Hovold
2024-03-13  1:30     ` Alex Henrie
2024-03-13  8:24       ` Johan Hovold
2024-03-26 15:07   ` [PATCH v2 0/4] usb: misc: uss720: improve support for Belkin F5U002 devices Alex Henrie
2024-03-26 15:07     ` [PATCH v2 1/4] usb: misc: uss720: point pp->dev to usbdev->dev Alex Henrie
2024-03-26 20:14       ` Sudip Mukherjee
2024-03-26 15:07     ` [PATCH v2 2/4] usb: misc: uss720: document the names of the compatible devices Alex Henrie
2024-03-26 15:07     ` [PATCH v2 3/4] usb: misc: uss720: add support for another variant of the Belkin F5U002 Alex Henrie
2024-03-26 15:07     ` [PATCH v2 4/4] usb: misc: uss720: check for incompatible versions " Alex Henrie
2024-03-12  5:50 ` [PATCH 5/7] usb: misc: uss720: document the names of the compatible devices Alex Henrie
2024-03-12 16:00   ` Daniel Gimpelevich
2024-03-12  5:50 ` Alex Henrie [this message]
2024-03-12 15:31   ` [PATCH 6/7] usb: misc: uss720: add support for another variant of the Belkin F5U002 Daniel Gimpelevich
2024-03-13  1:22     ` Alex Henrie
2024-03-12  5:50 ` [PATCH 7/7] usb: misc: uss720: check for incompatible versions " Alex Henrie
2024-03-12  7:38 ` [PATCH 1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP Johan Hovold
2024-03-12 15:24   ` Daniel Gimpelevich
2024-03-13  1:18     ` Alex Henrie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240312055350.205878-6-alexhenrie24@gmail.com \
    --to=alexhenrie24@gmail.com \
    --cc=daniel@gimpelevich.san-francisco.ca.us \
    --cc=hkzlabnet@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-parport@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mike@trausch.us \
    --cc=reboots@g-cipher.net \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox