From: Alex Henrie <alexhenrie24@gmail.com>
To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org,
sudipm.mukherjee@gmail.com, johan@kernel.org,
daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com,
reboots@g-cipher.net, mike@trausch.us,
gregkh@linuxfoundation.org
Cc: Alex Henrie <alexhenrie24@gmail.com>
Subject: [PATCH v2 1/4] usb: misc: uss720: point pp->dev to usbdev->dev
Date: Tue, 26 Mar 2024 09:07:08 -0600 [thread overview]
Message-ID: <20240326150723.99939-2-alexhenrie24@gmail.com> (raw)
In-Reply-To: <20240326150723.99939-1-alexhenrie24@gmail.com>
This avoids a "fix this legacy no-device port driver" warning from
parport_announce_port in drivers/parport/share.c. The parport driver now
requires a pointer to the device struct.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
drivers/usb/misc/uss720.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index b00d92db5dfd..1c940608deb5 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -720,6 +720,7 @@ static int uss720_probe(struct usb_interface *intf,
priv->pp = pp;
pp->private_data = priv;
pp->modes = PARPORT_MODE_PCSPP | PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_ECP | PARPORT_MODE_COMPAT;
+ pp->dev = &usbdev->dev;
/* set the USS720 control register to manual mode, no ECP compression, enable all ints */
set_1284_register(pp, 7, 0x00, GFP_KERNEL);
--
2.44.0
next prev parent reply other threads:[~2024-03-26 15:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 5:50 [PATCH 1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP Alex Henrie
2024-03-12 5:50 ` [PATCH 2/7] usb: serial: mos7720: don't advertise PARPORT_MODE_PCSPP Alex Henrie
2024-03-12 7:39 ` Johan Hovold
2024-03-12 9:53 ` Sudip Mukherjee
2024-03-12 15:27 ` Daniel Gimpelevich
2024-03-13 1:30 ` Alex Henrie
2024-03-26 9:10 ` Greg KH
2024-03-12 5:50 ` [PATCH 3/7] usb: misc: uss720: " Alex Henrie
2024-03-12 5:50 ` [PATCH 4/7] usb: misc: uss720: point pp->dev to usbdev->dev Alex Henrie
2024-03-12 7:40 ` Johan Hovold
2024-03-13 1:30 ` Alex Henrie
2024-03-13 8:24 ` Johan Hovold
2024-03-26 15:07 ` [PATCH v2 0/4] usb: misc: uss720: improve support for Belkin F5U002 devices Alex Henrie
2024-03-26 15:07 ` Alex Henrie [this message]
2024-03-26 20:14 ` [PATCH v2 1/4] usb: misc: uss720: point pp->dev to usbdev->dev Sudip Mukherjee
2024-03-26 15:07 ` [PATCH v2 2/4] usb: misc: uss720: document the names of the compatible devices Alex Henrie
2024-03-26 15:07 ` [PATCH v2 3/4] usb: misc: uss720: add support for another variant of the Belkin F5U002 Alex Henrie
2024-03-26 15:07 ` [PATCH v2 4/4] usb: misc: uss720: check for incompatible versions " Alex Henrie
2024-03-12 5:50 ` [PATCH 5/7] usb: misc: uss720: document the names of the compatible devices Alex Henrie
2024-03-12 16:00 ` Daniel Gimpelevich
2024-03-12 5:50 ` [PATCH 6/7] usb: misc: uss720: add support for another variant of the Belkin F5U002 Alex Henrie
2024-03-12 15:31 ` Daniel Gimpelevich
2024-03-13 1:22 ` Alex Henrie
2024-03-12 5:50 ` [PATCH 7/7] usb: misc: uss720: check for incompatible versions " Alex Henrie
2024-03-12 7:38 ` [PATCH 1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP Johan Hovold
2024-03-12 15:24 ` Daniel Gimpelevich
2024-03-13 1:18 ` Alex Henrie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326150723.99939-2-alexhenrie24@gmail.com \
--to=alexhenrie24@gmail.com \
--cc=daniel@gimpelevich.san-francisco.ca.us \
--cc=gregkh@linuxfoundation.org \
--cc=hkzlabnet@gmail.com \
--cc=johan@kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mike@trausch.us \
--cc=reboots@g-cipher.net \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox