* [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF
@ 2024-10-05 14:41 Jonathan Marek
2024-10-06 11:21 ` Bryan O'Donoghue
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jonathan Marek @ 2024-10-05 14:41 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bryan O'Donoghue, Heikki Krogerus, Greg Kroah-Hartman,
Caleb Connolly, Guenter Roeck,
open list:QUALCOMM TYPEC PORT MANAGER DRIVER, open list
This line is overwriting the result of the above switch-case.
This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop.
Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
index a747baa297849..c37dede62e12c 100644
--- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
+++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
@@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc,
val = TYPEC_CC_RP_DEF;
break;
}
- val = TYPEC_CC_RP_DEF;
}
if (misc & CC_ORIENTATION)
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF
2024-10-05 14:41 [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF Jonathan Marek
@ 2024-10-06 11:21 ` Bryan O'Donoghue
2024-10-06 15:41 ` Dmitry Baryshkov
2024-10-09 8:32 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2024-10-06 11:21 UTC (permalink / raw)
To: Jonathan Marek, linux-arm-msm
Cc: Heikki Krogerus, Greg Kroah-Hartman, Caleb Connolly,
Guenter Roeck, open list:QUALCOMM TYPEC PORT MANAGER DRIVER,
open list
On 05/10/2024 15:41, Jonathan Marek wrote:
> This line is overwriting the result of the above switch-case.
>
> This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> index a747baa297849..c37dede62e12c 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> @@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc,
> val = TYPEC_CC_RP_DEF;
> break;
> }
> - val = TYPEC_CC_RP_DEF;
> }
>
> if (misc & CC_ORIENTATION)
Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF
2024-10-05 14:41 [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF Jonathan Marek
2024-10-06 11:21 ` Bryan O'Donoghue
@ 2024-10-06 15:41 ` Dmitry Baryshkov
2024-10-09 8:32 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2024-10-06 15:41 UTC (permalink / raw)
To: Jonathan Marek
Cc: linux-arm-msm, Bryan O'Donoghue, Heikki Krogerus,
Greg Kroah-Hartman, Caleb Connolly, Guenter Roeck,
open list:QUALCOMM TYPEC PORT MANAGER DRIVER, open list
On Sat, Oct 05, 2024 at 10:41:46AM GMT, Jonathan Marek wrote:
> This line is overwriting the result of the above switch-case.
>
> This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF
2024-10-05 14:41 [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF Jonathan Marek
2024-10-06 11:21 ` Bryan O'Donoghue
2024-10-06 15:41 ` Dmitry Baryshkov
@ 2024-10-09 8:32 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2024-10-09 8:32 UTC (permalink / raw)
To: Jonathan Marek
Cc: linux-arm-msm, Bryan O'Donoghue, Greg Kroah-Hartman,
Caleb Connolly, Guenter Roeck,
open list:QUALCOMM TYPEC PORT MANAGER DRIVER, open list
On Sat, Oct 05, 2024 at 10:41:46AM -0400, Jonathan Marek wrote:
> This line is overwriting the result of the above switch-case.
>
> This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> index a747baa297849..c37dede62e12c 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> @@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc,
> val = TYPEC_CC_RP_DEF;
> break;
> }
> - val = TYPEC_CC_RP_DEF;
> }
>
> if (misc & CC_ORIENTATION)
> --
> 2.45.1
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-09 8:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-05 14:41 [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF Jonathan Marek
2024-10-06 11:21 ` Bryan O'Donoghue
2024-10-06 15:41 ` Dmitry Baryshkov
2024-10-09 8:32 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox