* [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support
@ 2025-01-25 9:40 U Michel
2025-02-03 15:16 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: U Michel @ 2025-01-25 9:40 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, U M
From: U M <ulv@on2.de>
Update the USB serial option driver to support Wistron NeWeb M18QW.
ID 1435:3185 WNC M18QW
T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
P: Vendor=1435 ProdID=3185 Rev= 3.18
S: Manufacturer=Android
S: Product=Android
S: SerialNumber=WNC_ADB
C:* #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
E: Ad=88(I) Atr=03(Int.) MxPS= 8 Ivl=32ms
E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 5 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=(none)
E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us
Tested successfully connecting via picocom and submitting at commands
Signed-off-by: U M <ulv@on2.de>
---
drivers/usb/serial/option.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 1e2ae0c6c41c..b166f1607b0e 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2285,6 +2285,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */
{ USB_DEVICE_INTERFACE_CLASS(0x1435, 0xd191, 0xff), /* Wistron Neweb D19Q1 */
.driver_info = RSVD(1) | RSVD(4) },
+ { USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) }, /* Wistron Neweb M18QW */
{ USB_DEVICE_INTERFACE_CLASS(0x1690, 0x7588, 0xff), /* ASKEY WWHC050 */
.driver_info = RSVD(1) | RSVD(4) },
{ USB_DEVICE_INTERFACE_CLASS(0x2020, 0x2031, 0xff), /* Olicard 600 */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support
2025-01-25 9:40 [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support U Michel
@ 2025-02-03 15:16 ` Greg Kroah-Hartman
2025-02-03 15:51 ` AW: " Ulv Michel
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2025-02-03 15:16 UTC (permalink / raw)
To: U Michel; +Cc: Johan Hovold, linux-usb, linux-kernel
On Sat, Jan 25, 2025 at 10:40:05AM +0100, U Michel wrote:
> From: U M <ulv@on2.de>
We need a full name, sorry.
And where is patch 1/2 of this series?
>
> Update the USB serial option driver to support Wistron NeWeb M18QW.
>
> ID 1435:3185 WNC M18QW
>
> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=1435 ProdID=3185 Rev= 3.18
> S: Manufacturer=Android
> S: Product=Android
> S: SerialNumber=WNC_ADB
> C:* #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> E: Ad=88(I) Atr=03(Int.) MxPS= 8 Ivl=32ms
> E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 5 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=(none)
> E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us
>
> Tested successfully connecting via picocom and submitting at commands
>
> Signed-off-by: U M <ulv@on2.de>
> ---
> drivers/usb/serial/option.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 1e2ae0c6c41c..b166f1607b0e 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2285,6 +2285,7 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */
> { USB_DEVICE_INTERFACE_CLASS(0x1435, 0xd191, 0xff), /* Wistron Neweb D19Q1 */
> .driver_info = RSVD(1) | RSVD(4) },
> + { USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) }, /* Wistron Neweb M18QW */
You forgot a tab before the comment :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* AW: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support
2025-02-03 15:16 ` Greg Kroah-Hartman
@ 2025-02-03 15:51 ` Ulv Michel
2025-02-11 14:25 ` Johan Hovold
0 siblings, 1 reply; 4+ messages in thread
From: Ulv Michel @ 2025-02-03 15:51 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Johan Hovold, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Hello Greg,
> We need a full name, sorry.
the full name is Ulv Michel.
> And where is patch 1/2 of this series?
Part 1 is this: https://lore.kernel.org/linux-usb/2025012501-pediatric-abide-b802@gregkh/T/#t
> > .driver_info = RSVD(1) | RSVD(4) },
> > + { USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) }, /* Wistron Neweb M18QW */
> You forgot a tab before the comment :(
:( I removed the tab because the checkpatch.pl complained the length of the line being more than 100 columns...
What would be you suggestion? Resubmit? Or keep it?
Thanks,
Ulv
-----Ursprüngliche Nachricht-----
Von: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gesendet: Montag, 3. Februar 2025 16:17
An: Ulv Michel <ulv@on2.de>
Cc: Johan Hovold <johan@kernel.org>; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
Betreff: Re: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support
On Sat, Jan 25, 2025 at 10:40:05AM +0100, U Michel wrote:
> From: U M <ulv@on2.de>
We need a full name, sorry.
And where is patch 1/2 of this series?
>
> Update the USB serial option driver to support Wistron NeWeb M18QW.
>
> ID 1435:3185 WNC M18QW
>
> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=1435 ProdID=3185 Rev= 3.18
> S: Manufacturer=Android
> S: Product=Android
> S: SerialNumber=WNC_ADB
> C:* #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> E: Ad=88(I) Atr=03(Int.) MxPS= 8 Ivl=32ms
> E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 5 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=(none)
> E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us
>
> Tested successfully connecting via picocom and submitting at commands
>
> Signed-off-by: U M <ulv@on2.de>
> ---
> drivers/usb/serial/option.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 1e2ae0c6c41c..b166f1607b0e 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2285,6 +2285,7 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */
> { USB_DEVICE_INTERFACE_CLASS(0x1435, 0xd191, 0xff), /* Wistron Neweb D19Q1 */
> .driver_info = RSVD(1) | RSVD(4) },
> + { USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) }, /* Wistron Neweb M18QW */
You forgot a tab before the comment :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: AW: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support
2025-02-03 15:51 ` AW: " Ulv Michel
@ 2025-02-11 14:25 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2025-02-11 14:25 UTC (permalink / raw)
To: Ulv Michel
Cc: Greg Kroah-Hartman, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
On Mon, Feb 03, 2025 at 03:51:52PM +0000, Ulv Michel wrote:
> Hello Greg,
>
> > We need a full name, sorry.
> the full name is Ulv Michel.
>
> > And where is patch 1/2 of this series?
> Part 1 is this: https://lore.kernel.org/linux-usb/2025012501-pediatric-abide-b802@gregkh/T/#t
Looks like something went wrong with the threading when you submitted
this series.
You can resend the patches individually if you prefer since they go
through different trees anyway, but you should get your mail setup fixed
for future contributions anyway.
Try sending it to yourself first.
> > > .driver_info = RSVD(1) | RSVD(4) },
> > > + { USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) }, /* Wistron Neweb M18QW */
>
> > You forgot a tab before the comment :(
> :( I removed the tab because the checkpatch.pl complained the length of the line being more than 100 columns...
> What would be you suggestion? Resubmit? Or keep it?
It's ok with lines longer than 100 columns here in these tables.
Please submit a v2 with your full name in From and in the SoB tags as
well.
One more comment below.
> -----Ursprüngliche Nachricht-----
> Von: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Gesendet: Montag, 3. Februar 2025 16:17
> An: Ulv Michel <ulv@on2.de>
> Cc: Johan Hovold <johan@kernel.org>; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support
>
> On Sat, Jan 25, 2025 at 10:40:05AM +0100, U Michel wrote:
> > From: U M <ulv@on2.de>
>
> We need a full name, sorry.
>
> And where is patch 1/2 of this series?
> > Signed-off-by: U M <ulv@on2.de>
> > ---
> > drivers/usb/serial/option.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 1e2ae0c6c41c..b166f1607b0e 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -2285,6 +2285,7 @@ static const struct usb_device_id option_ids[] = {
> > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */
> > { USB_DEVICE_INTERFACE_CLASS(0x1435, 0xd191, 0xff), /* Wistron Neweb D19Q1 */
> > .driver_info = RSVD(1) | RSVD(4) },
> > + { USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) }, /* Wistron Neweb M18QW */
And try to keep the entries sorted by VID/PID when possible (e.g. within
this Wistron subsection).
> You forgot a tab before the comment :(
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-11 14:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-25 9:40 [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support U Michel
2025-02-03 15:16 ` Greg Kroah-Hartman
2025-02-03 15:51 ` AW: " Ulv Michel
2025-02-11 14:25 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox