[PATCH next 1/3] dt-bindings: usb: microchip,usb2514: add support for vdda

[PATCH next 1/3] dt-bindings: usb: microchip,usb2514: add support for vdda

[Catalin Popescu]

Microchip hub USB2514 has one 3V3 digital power supply and one 3V3
analog power supply. Add support for analog power supply vdda.

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
 .../bindings/usb/microchip,usb2514.yaml           | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
index b14e6f37b298..743f7a22f13d 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
@@ -28,6 +28,9 @@ properties:
   vdd-supply:
     description: 3.3V power supply.
 
+  vdda-supply:
+    description: 3.3V analog power supply.
+
   clocks:
     description: External 24MHz clock connected to the CLKIN pin.
     maxItems: 1
@@ -36,6 +39,18 @@ required:
   - compatible
   - reg
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: usb424,2514
+then:
+  properties:
+    vdda-supply: true
+else:
+  properties:
+    vdda-supply: false
+
 patternProperties:
   "^.*@[0-9a-f]{1,2}$":
     description: The hard wired USB devices

base-commit: df5d6180169ae06a2eac57e33b077ad6f6252440
prerequisite-patch-id: 0000000000000000000000000000000000000000
-- 
2.34.1

[PATCH next 2/3] dt-bindings: usb: microchip,usb2514: add support for USB2512/USB2513

[Catalin Popescu]

Extend support to Microchip hubs USB2512 & USB2513 which are identical
to USB2514 but offer less downstream ports (i.e. respectively 2 and 3
ports).

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
 .../bindings/usb/microchip,usb2514.yaml         | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
index 743f7a22f13d..d159cde04c84 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
@@ -14,11 +14,18 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - usb424,2412
-      - usb424,2417
-      - usb424,2514
-      - usb424,2517
+    oneOf:
+      - items:
+          - enum:
+              - usb424,2412
+              - usb424,2417
+              - usb424,2514
+              - usb424,2517
+      - items:
+          - enum:
+              - usb424,2512
+              - usb424,2513
+          - const: usb424,2514
 
   reg: true
 
-- 
2.34.1

Re: [PATCH next 2/3] dt-bindings: usb: microchip,usb2514: add support for USB2512/USB2513

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On Tue, Feb 11, 2025 at 11:58:38AM +0100, Catalin Popescu wrote:
> Extend support to Microchip hubs USB2512 & USB2513 which are identical
> to USB2514 but offer less downstream ports (i.e. respectively 2 and 3
> ports).
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
>  .../bindings/usb/microchip,usb2514.yaml         | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> index 743f7a22f13d..d159cde04c84 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> @@ -14,11 +14,18 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - usb424,2412
> -      - usb424,2417
> -      - usb424,2514
> -      - usb424,2517
> +    oneOf:
> +      - items:

This items isn't doing anything, as it only has one entry (the enum).

> +          - enum:
> +              - usb424,2412
> +              - usb424,2417
> +              - usb424,2514
> +              - usb424,2517
> +      - items:
> +          - enum:
> +              - usb424,2512
> +              - usb424,2513
> +          - const: usb424,2514
>  
>    reg: true
>  
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH next 3/3] usb: misc: onboard_dev: add vdda support for Microchip USB2514

[Catalin Popescu]

This hub is powered by digital and analog 3V3 power rails, so provide
the possibility to use different regulators for digital (vdd) and analog
(vdda) power rails.

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
 drivers/usb/misc/onboard_usb_dev.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h
index 317b3eb99c02..933797a7e084 100644
--- a/drivers/usb/misc/onboard_usb_dev.h
+++ b/drivers/usb/misc/onboard_usb_dev.h
@@ -23,6 +23,13 @@ static const struct onboard_dev_pdata microchip_usb424_data = {
 	.is_hub = true,
 };
 
+static const struct onboard_dev_pdata microchip_usb2514_data = {
+	.reset_us = 1,
+	.num_supplies = 2,
+	.supply_names = { "vdd", "vdda" },
+	.is_hub = true,
+};
+
 static const struct onboard_dev_pdata microchip_usb5744_data = {
 	.reset_us = 0,
 	.power_on_delay_us = 10000,
@@ -96,7 +103,7 @@ static const struct onboard_dev_pdata xmos_xvf3500_data = {
 
 static const struct of_device_id onboard_dev_match[] = {
 	{ .compatible = "usb424,2412", .data = &microchip_usb424_data, },
-	{ .compatible = "usb424,2514", .data = &microchip_usb424_data, },
+	{ .compatible = "usb424,2514", .data = &microchip_usb2514_data, },
 	{ .compatible = "usb424,2517", .data = &microchip_usb424_data, },
 	{ .compatible = "usb424,2744", .data = &microchip_usb5744_data, },
 	{ .compatible = "usb424,5744", .data = &microchip_usb5744_data, },
-- 
2.34.1

Re: [PATCH next 1/3] dt-bindings: usb: microchip,usb2514: add support for vdda

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1662 bytes --]

On Tue, Feb 11, 2025 at 11:58:37AM +0100, Catalin Popescu wrote:
> Microchip hub USB2514 has one 3V3 digital power supply and one 3V3
> analog power supply. Add support for analog power supply vdda.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
>  .../bindings/usb/microchip,usb2514.yaml           | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> index b14e6f37b298..743f7a22f13d 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> @@ -28,6 +28,9 @@ properties:
>    vdd-supply:
>      description: 3.3V power supply.
>  
> +  vdda-supply:
> +    description: 3.3V analog power supply.
> +
>    clocks:
>      description: External 24MHz clock connected to the CLKIN pin.
>      maxItems: 1
> @@ -36,6 +39,18 @@ required:
>    - compatible
>    - reg
>  
> +if:

This should be merged with the existing allOf, which should be moved
down to after the patternProperties section.

Cheers,
Conor.

> +  properties:
> +    compatible:
> +      contains:
> +        const: usb424,2514
> +then:
> +  properties:
> +    vdda-supply: true
> +else:
> +  properties:
> +    vdda-supply: false
> +
>  patternProperties:
>    "^.*@[0-9a-f]{1,2}$":
>      description: The hard wired USB devices
> 
> base-commit: df5d6180169ae06a2eac57e33b077ad6f6252440
> prerequisite-patch-id: 0000000000000000000000000000000000000000
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]