* [PATCH] Documentation: ABI: remove outdated USB power/level removal notice
@ 2026-05-30 23:34 Sardaruddin Syed
2026-05-31 7:50 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Sardaruddin Syed @ 2026-05-30 23:34 UTC (permalink / raw)
To: linux-usb; +Cc: stern, linux-kernel, Sardaruddin Syed
The sysfs power/level interface is still implemented and documented
despite the removal notice stating it would be removed after 2010.
Remove the outdated removal timeline while keeping the deprecation
notice and recommendation to use power/control instead.
Signed-off-by: Sardaruddin Syed <ssardaruddin2002@gmail.com>
---
Documentation/ABI/obsolete/sysfs-bus-usb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/ABI/obsolete/sysfs-bus-usb b/Documentation/ABI/obsolete/sysfs-bus-usb
index bd096d33fbc7..067016e62e11 100644
--- a/Documentation/ABI/obsolete/sysfs-bus-usb
+++ b/Documentation/ABI/obsolete/sysfs-bus-usb
@@ -26,6 +26,6 @@ Description:
initializes all non-hub devices in the "on" level. Some
drivers may change this setting when they are bound.
- This file is deprecated and will be removed after 2010.
+ This file is deprecated.
Use the power/control file instead; it does exactly the
same thing.
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: ABI: remove outdated USB power/level removal notice
2026-05-30 23:34 [PATCH] Documentation: ABI: remove outdated USB power/level removal notice Sardaruddin Syed
@ 2026-05-31 7:50 ` Greg KH
[not found] ` <CAEUfWQg7msH_qsER7nL5_855puJYsj4ztT+DrRThfbih8TObnw@mail.gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2026-05-31 7:50 UTC (permalink / raw)
To: Sardaruddin Syed; +Cc: linux-usb, stern, linux-kernel
On Sat, May 30, 2026 at 11:34:07PM +0000, Sardaruddin Syed wrote:
> The sysfs power/level interface is still implemented and documented
> despite the removal notice stating it would be removed after 2010.
>
> Remove the outdated removal timeline while keeping the deprecation
> notice and recommendation to use power/control instead.
>
> Signed-off-by: Sardaruddin Syed <ssardaruddin2002@gmail.com>
> ---
> Documentation/ABI/obsolete/sysfs-bus-usb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/obsolete/sysfs-bus-usb b/Documentation/ABI/obsolete/sysfs-bus-usb
> index bd096d33fbc7..067016e62e11 100644
> --- a/Documentation/ABI/obsolete/sysfs-bus-usb
> +++ b/Documentation/ABI/obsolete/sysfs-bus-usb
> @@ -26,6 +26,6 @@ Description:
> initializes all non-hub devices in the "on" level. Some
> drivers may change this setting when they are bound.
>
> - This file is deprecated and will be removed after 2010.
> + This file is deprecated.
> Use the power/control file instead; it does exactly the
> same thing.
Why not just remove it instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: ABI: remove outdated USB power/level removal notice
[not found] ` <CAEUfWQg7msH_qsER7nL5_855puJYsj4ztT+DrRThfbih8TObnw@mail.gmail.com>
@ 2026-06-04 6:45 ` Greg KH
2026-06-04 9:38 ` Bjørn Mork
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2026-06-04 6:45 UTC (permalink / raw)
To: SARDARUDDIN SYED; +Cc: linux-usb, stern, linux-kernel
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Jun 04, 2026 at 05:36:29AM +0530, SARDARUDDIN SYED wrote:
> Hi Greg,
>
> I looked into the history and current implementation of power/level.
>
> The attribute is still implemented in drivers/usb/core/sysfs.c and is still
> documented as a deprecated interface. The obsolete ABI entry was added when
> power/level was deprecated in favor of power/control, but the interface
> itself remains present.
>
> I wasn't sure whether you meant removing the obsolete documentation entry
> or removing the deprecated interface itself, so I wanted to clarify before
> sending a v2.
Why not remove both?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: ABI: remove outdated USB power/level removal notice
2026-06-04 6:45 ` Greg KH
@ 2026-06-04 9:38 ` Bjørn Mork
0 siblings, 0 replies; 4+ messages in thread
From: Bjørn Mork @ 2026-06-04 9:38 UTC (permalink / raw)
To: Greg KH; +Cc: SARDARUDDIN SYED, linux-usb, stern, linux-kernel
Greg KH <greg@kroah.com> writes:
>> I looked into the history and current implementation of power/level.
>>
>> The attribute is still implemented in drivers/usb/core/sysfs.c and is still
>> documented as a deprecated interface. The obsolete ABI entry was added when
>> power/level was deprecated in favor of power/control, but the interface
>> itself remains present.
>>
>> I wasn't sure whether you meant removing the obsolete documentation entry
>> or removing the deprecated interface itself, so I wanted to clarify before
>> sending a v2.
>
> Why not remove both?
Won't that break stuff for anyone still using the power/level attribute?
Time has proved that no one cares about deprecation warnings.
Why not implement Alans original wish in commit a90309860b09 ("USB:
deprecate the power/level sysfs attribute") instead:
It would be nice to replace power/level with a symlink to
power/control, but at the moment sysfs doesn't offer any way to do so.
I believe this has been possible since commit 9255782f7061 ("sysfs: Wrap
__compat_only_sysfs_link_entry_to_kobj function to change the symlink
name")
Bjørn
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-04 9:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-30 23:34 [PATCH] Documentation: ABI: remove outdated USB power/level removal notice Sardaruddin Syed
2026-05-31 7:50 ` Greg KH
[not found] ` <CAEUfWQg7msH_qsER7nL5_855puJYsj4ztT+DrRThfbih8TObnw@mail.gmail.com>
2026-06-04 6:45 ` Greg KH
2026-06-04 9:38 ` Bjørn Mork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox